Re: Testing 1.7: Crash on viewing properties of unique constraints

Hi developers! Hi Dave!

Testing pgAdmin III 1.7.0, rev 6292:6293. Client Win XP, hosts: Debian
Sarge / PG 8.1.8 and Debian Etch / PG 8.2.3.

When trying to view the properties of a primary key or unique
constraint, pgAdmin crashes instantly. I can reproduce it every time.
Does not happen with other types of constraints. Those two implement a
unique index, so maybe that's a lead ..

That's what I get in the logs:
postgres LOG: SSL SYSCALL error: Connection reset by peer
postgres LOG: could not receive data from client: Connection reset
by peer
postgres LOG: unexpected EOF on client connection
My connection is non-SSL, so I don't understand why it says "SSL
SYSCALL". But I don't think that has anything to do with the crash.

Regards
Erwin

Hi Erwin,

Erwin Brandstetter a écrit :
> Testing pgAdmin III 1.7.0, rev 6292:6293. Client Win XP, hosts: Debian
> Sarge / PG 8.1.8 and Debian Etch / PG 8.2.3.
>
>
> When trying to view the properties of a primary key or unique
> constraint, pgAdmin crashes instantly. I can reproduce it every time.
> Does not happen with other types of constraints. Those two implement a
> unique index, so maybe that's a lead ..
>

I think you get an old bug that I fixed on rev 6315 :
http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=rev

Thanks for your impressive testing.

Regards.

--
Guillaume.
<!-- http://abs.traduc.org/
http://lfs.traduc.org/
http://docs.postgresqlfr.org/ -->

guillaume(at)lelarge(dot)info wrote:
> I think you get an old bug that I fixed on rev 6315 :
> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=rev
>
> Thanks for your impressive testing.
>

So now you are fixing bugs before I can even report them? Outrageous! ;)
Maybe it's time for a new snapshot.

Regards
Erwin

Erwin Brandstetter a écrit :
> guillaume(at)lelarge(dot)info wrote:
>> I think you get an old bug that I fixed on rev 6315 :
>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=rev
>>
>> Thanks for your impressive testing.
>>
>
> So now you are fixing bugs before I can even report them? Outrageous! ;)

Yeah, I know. It seems quite impossible, but someone did it. He did
report this bug before you :)

> Maybe it's time for a new snapshot.

I remember Dave telling he will create a new snapshot quite soon.

--
Guillaume.
<!-- http://abs.traduc.org/
http://lfs.traduc.org/
http://docs.postgresqlfr.org/ -->

Guillaume Lelarge wrote:
> Erwin Brandstetter a écrit :
>> guillaume(at)lelarge(dot)info wrote:
>>> I think you get an old bug that I fixed on rev 6315 :
>>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=rev
>>>
>>> Thanks for your impressive testing.
>>>
>> So now you are fixing bugs before I can even report them? Outrageous! ;)
>
> Yeah, I know. It seems quite impossible, but someone did it. He did
> report this bug before you :)
>
>> Maybe it's time for a new snapshot.
>
> I remember Dave telling he will create a new snapshot quite soon.

Yeah, I intend to, I've just got a few emails queued up behind a nasty
debugger bug that I need to get through first.

/D

Hi Guillaume!

guillaume(at)lelarge(dot)info wrote:
> Hi Erwin,
>
> Erwin Brandstetter a écrit :
>
>> Testing pgAdmin III 1.7.0, rev 6292:6293. Client Win XP, hosts: Debian
>> Sarge / PG 8.1.8 and Debian Etch / PG 8.2.3.
>>
>>
>> When trying to view the properties of a primary key or unique
>> constraint, pgAdmin crashes instantly. I can reproduce it every time.
>> Does not happen with other types of constraints. Those two implement a
>> unique index, so maybe that's a lead ..
>>
>
> I think you get an old bug that I fixed on rev 6315 :
> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=re

I am testing rev 6357 now, and the problem is still present as reported.
Not the same bug, maybe?

Regards
Erwin

Erwin Brandstetter a écrit :
> Hi Guillaume!
>
> guillaume(at)lelarge(dot)info wrote:
>> Hi Erwin,
>>
>> Erwin Brandstetter a écrit :
>>
>>> Testing pgAdmin III 1.7.0, rev 6292:6293. Client Win XP, hosts: Debian
>>> Sarge / PG 8.1.8 and Debian Etch / PG 8.2.3.
>>>
>>>
>>> When trying to view the properties of a primary key or unique
>>> constraint, pgAdmin crashes instantly. I can reproduce it every time.
>>> Does not happen with other types of constraints. Those two implement a
>>> unique index, so maybe that's a lead ..
>>>
>>
>> I think you get an old bug that I fixed on rev 6315 :
>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=re
>
> I am testing rev 6357 now, and the problem is still present as reported.
> Not the same bug, maybe?
>

It seems you're right. I'll work on this tomorrow morning.

Thanks for the tests.

Regards.

--
Guillaume.
<!-- http://abs.traduc.org/
http://lfs.traduc.org/
http://docs.postgresqlfr.org/ -->

Guillaume Lelarge a écrit :
> Erwin Brandstetter a écrit :
>> Hi Guillaume!
>>
>> guillaume(at)lelarge(dot)info wrote:
>>> Hi Erwin,
>>>
>>> Erwin Brandstetter a écrit :
>>>
>>>> Testing pgAdmin III 1.7.0, rev 6292:6293. Client Win XP, hosts: Debian
>>>> Sarge / PG 8.1.8 and Debian Etch / PG 8.2.3.
>>>>
>>>>
>>>> When trying to view the properties of a primary key or unique
>>>> constraint, pgAdmin crashes instantly. I can reproduce it every time.
>>>> Does not happen with other types of constraints. Those two implement a
>>>> unique index, so maybe that's a lead ..
>>>>
>>> I think you get an old bug that I fixed on rev 6315 :
>>> http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=6315&view=re
>> I am testing rev 6357 now, and the problem is still present as reported.
>> Not the same bug, maybe?
>>
>
> It seems you're right. I'll work on this tomorrow morning.
>

OK, it should now be fixed. I've checked the whole source file.

Once again, thanks for your testing.

Regards.

--
Guillaume.
<!-- http://abs.traduc.org/
http://lfs.traduc.org/
http://docs.postgresqlfr.org/ -->