| Lists: | pgsql-patches |
|---|
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Regression tests |
| Date: | 2007-05-29 21:34:11 |
| Message-ID: | 465C9C53.2080806@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Joachim Wieland attempted to post this patch, but it appears to be gone.
I tried a repost, and notivced it got rejected because it was >100kb.
Let me repeat previous objections that it really should be possible to
post a patch >100kb.
That said, here's a gzipped version.
Joachim, once it comes through, feel free to post whatever comments you
had in your original mail.
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| pg_regression_msvc.3.diff.gz | application/x-gzip | 34.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Regression tests |
| Date: | 2007-05-29 23:02:05 |
| Message-ID: | 21931.1180479725@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Magnus Hagander <magnus(at)hagander(dot)net> writes:
> Joachim Wieland attempted to post this patch, but it appears to be gone.
I trust the applied version will contain neither Windows newlines nor
non-English comments.
regards, tom lane
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Regression tests |
| Date: | 2007-05-31 17:12:26 |
| Message-ID: | 465F01FA.5020709@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> Joachim Wieland attempted to post this patch, but it appears to be gone.
>
> I trust the applied version will contain neither Windows newlines nor
> non-English comments.
Certainly would assume so. I haven't actually looked at the patch yet, I
just forwarded it.
(And I may well be responsible for the windows newlines - it may have
happened when I gzipped it on a windows box)
//Magnus
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de> |
| Subject: | Re: Regression tests |
| Date: | 2007-06-09 20:55:55 |
| Message-ID: | 466B13DB.4060206@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> Joachim Wieland attempted to post this patch, but it appears to be gone.
> I tried a repost, and notivced it got rejected because it was >100kb.
> Let me repeat previous objections that it really should be possible to
> post a patch >100kb.
> That said, here's a gzipped version.
>
> Joachim, once it comes through, feel free to post whatever comments you
> had in your original mail.
Here's an updated version of this patch. I reversed some parts of where
files went, which made the patch a whole lot smaller and easier to read,
and changed a couple of smaller things.
I have not yet looked at the actual ecpg parts (except noticed that they
are working on msvc at least), just the changes to main regression
tests. But I wanted to send off my new version for others to look at as
well before I do that.
This is still WIP, but comments appreciated.
//Magnus
| Attachment | Content-Type | Size |
|---|---|---|
| regress.diff | text/plain | 39.6 KB |
| ecpg_schedule | text/plain | 886 bytes |
| pg_regress_ecpg.c | text/plain | 6.8 KB |
| pg_regress_main.c | text/plain | 2.0 KB |
| pg_regress.h | text/plain | 1.5 KB |
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org> |
| Cc: | Joachim Wieland <joe(at)mcknight(dot)de> |
| Subject: | Re: Regression tests |
| Date: | 2007-06-12 11:16:32 |
| Message-ID: | 20070612111632.GB3332@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Sat, Jun 09, 2007 at 10:55:55PM +0200, Magnus Hagander wrote:
> Magnus Hagander wrote:
> > Joachim Wieland attempted to post this patch, but it appears to be gone.
> > I tried a repost, and notivced it got rejected because it was >100kb.
> > Let me repeat previous objections that it really should be possible to
> > post a patch >100kb.
> > That said, here's a gzipped version.
> >
> > Joachim, once it comes through, feel free to post whatever comments you
> > had in your original mail.
>
> Here's an updated version of this patch. I reversed some parts of where
> files went, which made the patch a whole lot smaller and easier to read,
> and changed a couple of smaller things.
>
> I have not yet looked at the actual ecpg parts (except noticed that they
> are working on msvc at least), just the changes to main regression
> tests. But I wanted to send off my new version for others to look at as
> well before I do that.
>
> This is still WIP, but comments appreciated.
I have applied a fairly well reworked version of this. The big thing is
that I moved the building of the pgc code out of the regression test driver
and into the build system using msbuild.
I also did a couple of minor fixes to the threading tests and such.
//Magnus
| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>, Joachim Wieland <joe(at)mcknight(dot)de> |
| Subject: | Re: Regression tests |
| Date: | 2007-06-12 12:25:24 |
| Message-ID: | 20070612122524.GA18305@feivel.credativ.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Tue, Jun 12, 2007 at 01:16:32PM +0200, Magnus Hagander wrote:
> I have applied a fairly well reworked version of this. The big thing is
> that I moved the building of the pgc code out of the regression test driver
> and into the build system using msbuild.
>
> I also did a couple of minor fixes to the threading tests and such.
Thanks.
It seems you missed one file. make checktcp says:
pg_regress: could not open file "./ecpg_schedule_tcp" for reading
Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Meskes <meskes(at)postgresql(dot)org> |
| Cc: | PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>, Joachim Wieland <joe(at)mcknight(dot)de> |
| Subject: | Re: Regression tests |
| Date: | 2007-06-12 13:10:12 |
| Message-ID: | 20070612131012.GE3332@svr2.hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Tue, Jun 12, 2007 at 02:25:24PM +0200, Michael Meskes wrote:
> On Tue, Jun 12, 2007 at 01:16:32PM +0200, Magnus Hagander wrote:
> > I have applied a fairly well reworked version of this. The big thing is
> > that I moved the building of the pgc code out of the regression test driver
> > and into the build system using msbuild.
> >
> > I also did a couple of minor fixes to the threading tests and such.
>
> Thanks.
>
> It seems you missed one file. make checktcp says:
>
> pg_regress: could not open file "./ecpg_schedule_tcp" for reading
Oops, search/replace error. Fixed.
//Magnus