| Lists: | pgsql-patches |
|---|
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | document plperl argument and return value representation |
| Date: | 2007-05-03 22:24:19 |
| Message-ID: | 463A6113.8060206@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
The attached docs patch makes clearer how arguments and return values in
pl/perl are escaped. This is to clarify the situation that Theo
Schlossnagle recently reported on -bugs.
If there's no objection I will apply this.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| plperldoc.patch | text/x-patch | 1.5 KB |
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: document plperl argument and return value representation |
| Date: | 2007-05-03 22:52:48 |
| Message-ID: | 20070503225248.GL4218@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Andrew Dunstan wrote:
>
> The attached docs patch makes clearer how arguments and return values in
> pl/perl are escaped. This is to clarify the situation that Theo
> Schlossnagle recently reported on -bugs.
I find the mix of arguments and results a bit confusing. Maybe you
could put them in separate paragraphs.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: document plperl argument and return value representation |
| Date: | 2007-05-03 23:47:04 |
| Message-ID: | 463A7478.7070906@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Alvaro Herrera wrote:
> Andrew Dunstan wrote:
>
>> The attached docs patch makes clearer how arguments and return values in
>> pl/perl are escaped. This is to clarify the situation that Theo
>> Schlossnagle recently reported on -bugs.
>>
>
> I find the mix of arguments and results a bit confusing. Maybe you
> could put them in separate paragraphs.
>
>
Is this better?
I also took the opportunity to replace an unbalanced quote mark that was
screwing up the syntax highlighting.
cheers
andrew
| Attachment | Content-Type | Size |
|---|---|---|
| plperldoc.patch | text/x-patch | 2.0 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: document plperl argument and return value representation |
| Date: | 2007-05-04 02:44:42 |
| Message-ID: | 9445.1178246682@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Is this better?
I suggest bytea -> <type>bytea</>, otherwise seems fine.
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: document plperl argument and return value representation |
| Date: | 2007-05-04 13:46:27 |
| Message-ID: | 20070504134627.GA11413@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Andrew Dunstan wrote:
>
>
> Alvaro Herrera wrote:
> >Andrew Dunstan wrote:
> >
> >>The attached docs patch makes clearer how arguments and return values in
> >>pl/perl are escaped. This is to clarify the situation that Theo
> >>Schlossnagle recently reported on -bugs.
> >>
> >
> >I find the mix of arguments and results a bit confusing. Maybe you
> >could put them in separate paragraphs.
>
> Is this better?
Yup, looks very nice.
This message also serves to test whether I removed the annoying
Mail-Followup-To header. It was actually a _feature_ of mutt
(followup_to, which fired when I replied to a list to which I'm
subscribed), which I disabled. Sorry about that.
ETOOMANYWHICH, sorry about that as well :-)
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.