Re: pgevent warnings on mingw

Ooops, sorry., One mistake:-(
Please this.

----- Original Message -----
From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>

> Hi.
>
> I am checking that consider sufficient test as Marko-san and it is satisfactory.
> However, That there is a portion which does not suit the solution of MSVC
> also understands. Therefore, How is this proposal?
>
> 1. )remove pgevent.def
> It is always generated.
>
> 2.) improvement of the Makefile and Solution.pm
>
> What do you think?
>
> Regards,
> Hiroshi Saito

Ahh, sorry..like the spam....
again!

I thought over that the existing msvc the did not have uneasines.
so, I wish to make it this as correspondence with worried Magnus-san.
It is after sufficient test.

Regards,
Hiroshi Saito

----- Original Message -----
From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>

> Ooops, sorry., One mistake:-(
> Please this.
>
> ----- Original Message -----
> From: "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
>
>
>> Hi.
>>
>> I am checking that consider sufficient test as Marko-san and it is satisfactory.
>> However, That there is a portion which does not suit the solution of MSVC
>> also understands. Therefore, How is this proposal?
>>
>> 1. )remove pgevent.def
>> It is always generated.
>>
>> 2.) improvement of the Makefile and Solution.pm
>>
>> What do you think?
>>
>> Regards,
>> Hiroshi Saito
>

--------------------------------------------------------------------------------

>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>

Hiroshi Saito wrote:
> Ahh, sorry..like the spam....
> again!
>
> I thought over that the existing msvc the did not have uneasines.
> so, I wish to make it this as correspondence with worried Magnus-san.
> It is after sufficient test.

If I read this patch right, it does an "export all symbols" when run on
mingw? That surely can't be right? We may not have any additional
symbols there now, but it's certaily not the intention? Plus, it makes
msvc behave differently from mingw (since msvc uses the exports.txt)?

I did some more checking, and it seems MS has changed the warnings in
the new version of VIsual Studio. Right now, the following exports.txt
file passes without warnings. Can someone check if it does on mingw?

EXPORTS
DllUnregisterServer @ 1;
DllRegisterServer @ 2;

Do you need all that extra decoration junk on mingw, or does it work
this way?

//Magnus

----- Original Message -----
From: "Magnus Hagander" <magnus(at)hagander(dot)net>

> Hiroshi Saito wrote:
>> Ahh, sorry..like the spam....
>> again!
>>
>> I thought over that the existing msvc the did not have uneasines.
>> so, I wish to make it this as correspondence with worried Magnus-san.
>> It is after sufficient test.
>
> If I read this patch right, it does an "export all symbols" when run on
> mingw? That surely can't be right? We may not have any additional
> symbols there now, but it's certaily not the intention? Plus, it makes
> msvc behave differently from mingw (since msvc uses the exports.txt)?
>
> I did some more checking, and it seems MS has changed the warnings in
> the new version of VIsual Studio. Right now, the following exports.txt
> file passes without warnings. Can someone check if it does on mingw?
>
> EXPORTS
> DllUnregisterServer @ 1;
> DllRegisterServer @ 2;
>
>
> Do you need all that extra decoration junk on mingw, or does it work
> this way?

It was checked.

$ cat pgevent.def
EXPORTS
DllUnregisterServer @ 1;
DllRegisterServer @ 2;

$ make
gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing
-fwrapv -g -I../../../src/include -I/C/work/MinGW_WORK/include -I./src/include/port/win32 -DEXEC_BACKEND
"-I../../../src/include/port/win32" -c -o pgevent.o pgevent.c
sed -e 's;FILEDESC;"Eventlog message formatter";' -e 's;VFT_APP;VFT_DLL;' -e 's;_ICO_;;' -e
's;\(VERSION.*\),0 *$;\1,'`date '+%y%j' | sed 's/^0*//'`';' ../../../src/port/win32ver.rc
>win32ver.rc
windres pgmsgevent.rc -o
pgmsgevent.o --include-dir=../../../src/include --include-dir=../../../src/include --include-dir=.
dllwrap --def pgevent.def -o pgevent.dll pgevent.o pgmsgevent.o
Warning: resolving _DllUnregisterServer by linking to _DllUnregisterServer(at)0
Use --enable-stdcall-fixup to disable these warnings
Use --disable-stdcall-fixup to disable these fixups
Warning: resolving _DllRegisterServer by linking to _DllRegisterServer(at)0
Warning: resolving _DllUnregisterServer by linking to _DllUnregisterServer(at)0
Use --enable-stdcall-fixup to disable these warnings
Use --disable-stdcall-fixup to disable these fixups
Warning: resolving _DllRegisterServer by linking to _DllRegisterServer(at)0

Regards,
Hiroshi Saito