| Lists: | pgsql-hackers |
|---|
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | installcheck-parallel |
| Date: | 2006-08-06 23:33:25 |
| Message-ID: | 44D67C45.8020806@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
I see that the installcheck-parallel was not added to the top level
Makefile and Gnumakefile.in when it was added as a regression test
target back in the 8.0 cycle. Is there any objection to my adding it now
so that it is treated the same as the other regression test targets? If
so, should I add it just to HEAD, or backpatch it to 8.0 and 8.1?
(Reasoning: I got confused for a few seconds and thought maybe I had
mistyped the target name, before I realised what was wrong, but others
less familiar than I am with the testing structure might well get rather
more confused.)
cheers
andrew
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: installcheck-parallel |
| Date: | 2006-08-18 13:50:34 |
| Message-ID: | 44E5C5AA.7030203@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
>
> I see that the installcheck-parallel was not added to the top level
> Makefile and Gnumakefile.in when it was added as a regression test
> target back in the 8.0 cycle. Is there any objection to my adding it
> now so that it is treated the same as the other regression test
> targets? If so, should I add it just to HEAD, or backpatch it to 8.0
> and 8.1? (Reasoning: I got confused for a few seconds and thought
> maybe I had mistyped the target name, before I realised what was
> wrong, but others less familiar than I am with the testing structure
> might well get rather more confused.)
>
I didn't get any response to this so I'm going to add this and back port
it, since the risk factor is pretty well zero, and I suspect it was just
an inadvertent omission a couple of years ago.
cheers
andrew
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: installcheck-parallel |
| Date: | 2006-08-18 15:10:30 |
| Message-ID: | 200608181510.k7IFAUl06385@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Andrew Dunstan wrote:
> Andrew Dunstan wrote:
> >
> > I see that the installcheck-parallel was not added to the top level
> > Makefile and Gnumakefile.in when it was added as a regression test
> > target back in the 8.0 cycle. Is there any objection to my adding it
> > now so that it is treated the same as the other regression test
> > targets? If so, should I add it just to HEAD, or backpatch it to 8.0
> > and 8.1? (Reasoning: I got confused for a few seconds and thought
> > maybe I had mistyped the target name, before I realised what was
> > wrong, but others less familiar than I am with the testing structure
> > might well get rather more confused.)
> >
>
> I didn't get any response to this so I'm going to add this and back port
> it, since the risk factor is pretty well zero, and I suspect it was just
> an inadvertent omission a couple of years ago.
Agreed.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +