Re: 2WRS [WIP]

HI.

I send you the diff of my code against the current CVS TIP.
Please tell me if it's what you were asking for.

Thanks.

Regards, Manolo di Domenico

----------------------------------------
> Date: Wed, 6 Feb 2008 17:03:16 -0800
> From: david(at)fetter(dot)org
> To: mac_man2005(at)hotmail(dot)it
> Subject: Re: [PATCHES] 2WRS [WIP]
>
>
> Go here and snoop around a bit.
>
> http://neilconway.org/talks/hacking
_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE!
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/

On Feb 7, 2008 6:04 AM, Manolo _ <mac_man2005(at)hotmail(dot)it> wrote:
>
> HI.
>
> I send you the diff of my code against the current CVS TIP.
> Please tell me if it's what you were asking for.
>

not actually, because your patch removes an improvement that was
included in 8.3...
what you will have to do (if someone has a better solution feel free
to comment on this) is to manually merge your 8.2's patch into the
8.3's source and then generate a diff

another sugestion is to comment a little more your code. simply put a
mark where you modify something is not a comment, specially if you can
get that info from a simple cvs diff

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

On Fri, Feb 08, 2008 at 12:27:23AM -0500, Jaime Casanova wrote:
> On Feb 7, 2008 6:04 AM, Manolo _ <mac_man2005(at)hotmail(dot)it> wrote:
> >
> > HI.
> >
> > I send you the diff of my code against the current CVS TIP.
> > Please tell me if it's what you were asking for.
> >
>
> not actually, because your patch removes an improvement that was
> included in 8.3...
> what you will have to do (if someone has a better solution feel free
> to comment on this) is to manually merge your 8.2's patch into the
> 8.3's source and then generate a diff

s/8.3/HEAD/
--
Decibel!, aka Jim C. Nasby, Database Architect decibel(at)decibel(dot)org
Give your computer some brain candy! www.distributed.net Team #1828

Hi.

That's the last release and refers to 8.3.0 and not to 8.2.5 as before. Hope
you can tell me if I created it correctly please.

Thanks.
Regards, Manolo.

On Thu, Feb 21, 2008 at 6:44 AM, <manolo(dot)espa(at)gmail(dot)com> wrote:
> Hi.
>
> That's the last release and refers to 8.3.0 and not to 8.2.5 as before. Hope
> you can tell me if I created it correctly please.
>

no, it doesn't...

> ! /* GUC variables */
> #ifdef TRACE_SORT
> bool trace_sort = false;
> #endif
> - #ifdef DEBUG_BOUNDED_SORT
> - bool optimize_bounded_sort = true;
> - #endif

it's seems you're removing something added in 8.3

--
regards,
Jaime Casanova

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs and the universe trying
to produce bigger and better idiots.
So far, the universe is winning."
Richard Cook

For the joy of all of you: that's the correct WIP patch.
At the moment it only tries to create runs uding two heaps. Hope you can
help me with writing those runs on tapes.

I'd be very pleased to give you more details.

Thenks for your time.
Regards, Manolo.

--------------------------------------------------
From: "Jaime Casanova" <systemguards(at)gmail(dot)com>
Sent: Friday, February 22, 2008 5:30 AM
To: <manolo(dot)espa(at)gmail(dot)com>
Cc: "Decibel!" <decibel(at)decibel(dot)org>; "Manolo _" <mac_man2005(at)hotmail(dot)it>;
"David Fetter" <david(at)fetter(dot)org>; <pgsql-patches(at)postgresql(dot)org>;
<pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] 2WRS [WIP]

> On Thu, Feb 21, 2008 at 6:44 AM, <manolo(dot)espa(at)gmail(dot)com> wrote:
>> Hi.
>>
>> That's the last release and refers to 8.3.0 and not to 8.2.5 as before.
>> Hope
>> you can tell me if I created it correctly please.
>>
>
> no, it doesn't...
>
>> ! /* GUC variables */
>> #ifdef TRACE_SORT
>> bool trace_sort = false;
>> #endif
>> - #ifdef DEBUG_BOUNDED_SORT
>> - bool optimize_bounded_sort = true;
>> - #endif
>
> it's seems you're removing something added in 8.3
>
> --
> regards,
> Jaime Casanova
>
> "Programming today is a race between software engineers striving to
> build bigger and better idiot-proof programs and the universe trying
> to produce bigger and better idiots.
> So far, the universe is winning."
> Richard Cook
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>

For the joy of all of you: that's the correct WIP patch.
At the moment it only tries to create runs uding two heaps. Hope you can
help me with writing those runs on tapes.

I'd be very pleased to give you more details.

Thenks for your time.
Regards, Manolo.

--------------------------------------------------
From: "Jaime Casanova" <systemguards(at)gmail(dot)com>
Sent: Friday, February 22, 2008 5:30 AM
To: <manolo(dot)espa(at)gmail(dot)com>
Cc: "Decibel!" <decibel(at)decibel(dot)org>; "Manolo _" <mac_man2005(at)hotmail(dot)it>;
"David Fetter" <david(at)fetter(dot)org>; <pgsql-patches(at)postgresql(dot)org>;
<pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] [PATCHES] 2WRS [WIP]

> On Thu, Feb 21, 2008 at 6:44 AM, <manolo(dot)espa(at)gmail(dot)com> wrote:
>> Hi.
>>
>> That's the last release and refers to 8.3.0 and not to 8.2.5 as before.
>> Hope
>> you can tell me if I created it correctly please.
>>
>
> no, it doesn't...
>
>> ! /* GUC variables */
>> #ifdef TRACE_SORT
>> bool trace_sort = false;
>> #endif
>> - #ifdef DEBUG_BOUNDED_SORT
>> - bool optimize_bounded_sort = true;
>> - #endif
>
> it's seems you're removing something added in 8.3
>
> --
> regards,
> Jaime Casanova
>
> "Programming today is a race between software engineers striving to
> build bigger and better idiot-proof programs and the universe trying
> to produce bigger and better idiots.
> So far, the universe is winning."
> Richard Cook
>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
> choose an index scan if your joining column's datatypes do not
> match
>

We need more testing to show this is a good idea.

---------------------------------------------------------------------------

Manolo _ wrote:
>
> HI.
>
> I send you the diff of my code against the current CVS TIP.
> Please tell me if it's what you were asking for.
>
> Thanks.
>
> Regards, Manolo di Domenico
>
> ----------------------------------------
> > Date: Wed, 6 Feb 2008 17:03:16 -0800
> > From: david(at)fetter(dot)org
> > To: mac_man2005(at)hotmail(dot)it
> > Subject: Re: [PATCHES] 2WRS [WIP]
> >
> >
> > Go here and snoop around a bit.
> >
> > http://neilconway.org/talks/hacking
> _________________________________________________________________
> Express yourself instantly with MSN Messenger! Download today it's FREE!
> http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/
[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +