Re: Lowercase folding - simple patch?

Lists: pgsql-odbc
From: "Merlin Moncure" <merlin(dot)moncure(at)rcsonline(dot)com>
To: "Eric E" <whalesuit(at)bonbon(dot)net>
Cc: <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Lowercase folding - simple patch?
Date: 2005-07-28 12:13:05
Message-ID: 6EE64EF3AB31D5448D0007DD34EEB3417DCF20@Herge.rcsinc.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-odbc

> did. It might also be worth dropping a line to Microsoft about this
> problem, as they have evidently made this work in Access, and I
believe
> quoting for mixed case is part of SQL92.

MS Query basically hasn't changed at all since 1997. Their preferred
way to do it is to embed vb code into the spreadsheet.

Merlin


From: Marko Ristola <Marko(dot)Ristola(at)kolumbus(dot)fi>
To: Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>
Cc: Eric E <whalesuit(at)bonbon(dot)net>, pgsql-odbc(at)postgresql(dot)org
Subject: Re: Lowercase folding - simple patch?
Date: 2005-08-01 16:27:58
Message-ID: 42EE4D8E.8010104@kolumbus.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-odbc


Does somebody know, wether the following code is correct:

odbcapi.c:

RETCODE SQL_API
SQLColumns(HSTMT StatementHandle, ...)
{
...

if (SC_is_lower_case(stmt, conn)) /* case-insensitive identifier */
ifallupper = FALSE;

In above there is one hidden problem:
SC_is_lower_case() is implemented as follows:

statement.h:#define SC_is_lower_case(a, b) (a->options.metadata_id,
b->connInfo.lower_case_identifier)

GCC compiler complaints (-Wall enabled) about the definition:

odbcapi.c:140: warning: left-hand operand of comma expression has no effect

So this means, that a->options.metadata_id is not used at all. Maybe the
comma
should be replaced with && or || ?

Marko Ristola