Re: PQmakeEmptyPGresult() will return NULL if allocation

PQmakeEmptyPGresult() will return NULL if malloc() fails for required
PGresult struct.

Volkan YAZICI wrote:
> PQmakeEmptyPGresult() will return NULL if malloc() fails for required
> PGresult struct.

Good catch. However, there's not much point having PQmakeEmptyPGresult()
return NULL on OOM if the various call sites of the function within
libpq don't check the return value and handle OOM themselves.

Some checking reveals that there are a few other bits of code in libpq
that don't handle malloc() failures correctly. I'll take a look at
fixing this today or tomorrow.

-Neil

Neil Conway wrote:
> Some checking reveals that there are a few other bits of code in libpq
> that don't handle malloc() failures correctly. I'll take a look at
> fixing this today or tomorrow.

Attached is a patch that implements this. This adds checking for most of
the call sites of strdup(), malloc(), PQmakeEmptyPGresult(),
pqResultAlloc(), and pqResultStrdup() in libpq. Barring any objections,
I'll apply this to HEAD tomorrow.

-Neil

Neil Conway wrote:
> Attached is a patch that implements this. This adds checking for most of
> the call sites of strdup(), malloc(), PQmakeEmptyPGresult(),
> pqResultAlloc(), and pqResultStrdup() in libpq. Barring any objections,
> I'll apply this to HEAD tomorrow.

Applied. Thanks for the report.

-Neil