bug fix - plperl %_SHARED misspelled

Lists: pgsql-patches
From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: bug fix - plperl %_SHARED misspelled
Date: 2005-05-21 20:58:42
Message-ID: 428FA102.4080902@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

While building some better plperl tests today I discovered a horrid bug
(which I regret to say is my fault), present in both 8.0 and HEAD
branches, The attached patch needs to be applied urgently to both
branches, please.

cheers

andrew

Index: plperl.c
===================================================================
RCS file: /projects/cvsroot/pgsql/src/pl/plperl/plperl.c,v
retrieving revision 1.73
diff -c -r1.73 plperl.c
*** plperl.c 6 May 2005 17:24:55 -0000 1.73
--- plperl.c 21 May 2005 20:56:02 -0000
***************
*** 226,232 ****
"$PLContainer->permit_only(':default');"
"$PLContainer->permit(qw[:base_math !:base_io sort time]);"
"$PLContainer->share(qw[&elog &spi_exec_query &DEBUG &LOG "
! "&INFO &NOTICE &WARNING &ERROR %SHARED ]);"
"sub ::mksafefunc { return $PLContainer->reval(qq[sub { $_[0]
$_[1]}]); }"
;

--- 226,232 ----
"$PLContainer->permit_only(':default');"
"$PLContainer->permit(qw[:base_math !:base_io sort time]);"
"$PLContainer->share(qw[&elog &spi_exec_query &DEBUG &LOG "
! "&INFO &NOTICE &WARNING &ERROR %_SHARED ]);"
"sub ::mksafefunc { return $PLContainer->reval(qq[sub { $_[0]
$_[1]}]); }"
;

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <neilc(at)samurai(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: bug fix - plperl %_SHARED misspelled
Date: 2005-05-23 01:45:04
Message-ID: 2214.24.211.165.134.1116812704.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Neil Conway said:
>
> BTW, in future it would be good to specify the consequences of the bug
> (i.e. beyond "it is horrible"), so committers who don't use pl/perl can
> judge the urgency of the bug.

Yes, sorry. In fact, fortuitously the effects are not disastrous in most
circumstances. Once we turn on strict mode they would become severe -
%_SHARED would be unusable. But fixing the error has zero downside impact.

cheers

andrew

From: Neil Conway <neilc(at)samurai(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: bug fix - plperl %_SHARED misspelled
Date: 2005-05-23 02:07:08
Message-ID: 42913ACC.30407@samurai.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Andrew Dunstan wrote:
> While building some better plperl tests today I discovered a horrid bug
> (which I regret to say is my fault), present in both 8.0 and HEAD
> branches

BTW, in future it would be good to specify the consequences of the bug
(i.e. beyond "it is horrible"), so committers who don't use pl/perl can
judge the urgency of the bug.

> The attached patch needs to be applied urgently to both
> branches, please.

Applied, thanks.

-Neil