Re: pgadminIII on OSX 10.3.9; w/ wxWidgets-2.6.0

hi all,

coming back from vacation :-( i noticed that wxwidgets 2.6.0 has been released,
and that there are now nightly OSX builds available (nice! florian)

after updating to OSX 10.3.9, i've done a sanity run for myself:

wxWidgets-CVS (4/25/05 11:34:29) & wxWidgets-2.6.0 both:

../configure \
--prefix=/usr/local/wxWidgets-cvs \
--with-mac \
--disable-shared \
--disable-debug \
--enable-unicode \
--with-regex

make
make install

w/o error, where:

% du -s -h /usr/local/wxWidgets-260/*
868K /usr/local/wxWidgets-260/bin
4.8M /usr/local/wxWidgets-260/include
16M /usr/local/wxWidgets-260/lib
12K /usr/local/wxWidgets-260/share

% ls -al /usr/local/wxWidgets-260/bin
total 868
drwxr-xr-x 5 root admin 170 Apr 25 15:18 .
drwxr-xr-x 6 root admin 204 Apr 25 15:18 ..
lrwxr-xr-x 1 root admin 69 Apr 25 15:18 wx-config ->
/usr/local/wxWidgets-260/lib/wx/config/mac-unicode-release-static-2.6
lrwxr-xr-x 1 root admin 8 Apr 25 15:18 wxrc -> wxrc-2.6
-rwxr-xr-x 1 devuser wheel 879000 Apr 25 13:26 wxrc-2.6

% du -s -h /usr/local/wxWidgets-cvs/*
968K /usr/local/wxWidgets-cvs/bin
4.8M /usr/local/wxWidgets-cvs/include
27M /usr/local/wxWidgets-cvs/lib
12K /usr/local/wxWidgets-cvs/share

% ls -al /usr/local/wxWidgets-cvs/bin
total 968
drwxr-xr-x 5 root admin 170 Apr 25 17:05 .
drwxr-xr-x 6 root admin 204 Apr 25 17:05 ..
lrwxr-xr-x 1 root admin 69 Apr 25 17:05 wx-config ->
/usr/local/wxWidgets-cvs/lib/wx/config/mac-unicode-release-static-2.6
lrwxr-xr-x 1 root admin 8 Apr 25 17:05 wxrc -> wxrc-2.6
-rwxr-xr-x 1 devuser wheel 980160 Apr 25 17:00 wxrc-2.6

subsequent builds of pgadmin3-cvs (4/25/05 04:04:22) as:

CASE XXX == 260, cvs

./configure \
--enable-appbundle \
--enable-static \
--disable-debug \
--with-wx=/usr/local/wxWidgets-XXX \
--with-wx-config=wx-config \
--with-pgsql=/usr/local/pgsql \
--with-pgsql-include=/usr/local/pgsql/include

make all
make install

--- (CASE wxwidgets-260) ------------------------------------------
no longer requires a chmod on complete-bundle.sh (thx!)

builds completely/successfully, but STILL fails to AUTOSTRIP correctly

% ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
-rwxr-xr-x 1 root admin 109540252 Apr 25 18:20
/usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

% strip /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

% ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
-rwxr-xr-x 1 root admin 7800208 Apr 25 18:24
/usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

the resultant executable launches from Finder w/o error, and initial poking
around is error free. yay!

--- (CASE wxwidgets-cvs) ------------------------------------------

no longer requires a chmod on complete-bundle.sh

configures OK

'make all' fails at:

ld: Undefined symbols:
wxAssert(int, wchar_t const*, int, wchar_t const*, wchar_t const*)
make[2]: *** [pgadmin3] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

i'll see what i can find out abt this one ...

cheers,

richard

OpenMacNews wrote:
> --- (CASE wxwidgets-260) ------------------------------------------
> no longer requires a chmod on complete-bundle.sh (thx!)
>
> builds completely/successfully, but STILL fails to AUTOSTRIP correctly
>
> % ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
> -rwxr-xr-x 1 root admin 109540252 Apr 25 18:20
> /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
>
> % strip /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
>
> % ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
> -rwxr-xr-x 1 root admin 7800208 Apr 25 18:24
> /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
Hm.. this is strange... I works for the nightly builds...
In src/Makefile.am, you should find the lines:
if test "$(pg_debug_build)" = "no"; then \
strip pgAdmin3 ;\
fi

Could you put an "echo $(pg_debug_build)" before the if,
and post the output?

> the resultant executable launches from Finder w/o error, and initial
> poking around is error free. yay!
good! ;-)

> --- (CASE wxwidgets-cvs) ------------------------------------------
>
> no longer requires a chmod on complete-bundle.sh
>
> configures OK
>
> 'make all' fails at:
>
> ld: Undefined symbols:
> wxAssert(int, wchar_t const*, int, wchar_t const*, wchar_t const*)
> make[2]: *** [pgadmin3] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all] Error 2
>
> i'll see what i can find out abt this one ...
Hm... the nighty build currently link against wx-cvs (because
2.6 wasn't released when I set the build-daemon up), and
it links sucessfully....

Did you "make clean" your source-tree after switching wx version?

greetings, Florian Pflug

hi florian,

>> --- (CASE wxwidgets-260) ------------------------------------------
...
>> builds completely/successfully, but STILL fails to AUTOSTRIP correctly
...
> Hm.. this is strange... I works for the nightly builds...
> In src/Makefile.am, you should find the lines:
> if test "$(pg_debug_build)" = "no"; then \
> strip pgAdmin3 ;\
> fi
>
> Could you put an "echo $(pg_debug_build)" before the if,
> and post the output?

ok. per request,

@216
mv tmp pgAdmin3 ;\
+++ echo $(pg_debug_build) ;\
if test "$(pg_debug_build)" = "no"; then \
strip pgAdmin3 ;\
fi

indeed, NO STRIP occurred:

% ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
-rwxr-xr-x 1 root admin 109540252 Apr 26 09:03
/usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

here's the 'make install' output ....
...
make install-exec-hook
cd /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS ;\
mv pgadmin3 tmp ;\
mv tmp pgAdmin3 ;\
echo yes ;\
if test "yes" = "no"; then \
strip pgAdmin3 ;\
fi
yes
...

hmmm, $pg_debug_build is reporting as YES despite my config as:

./configure \
--enable-appbundle \
--enable-static \
--disable-debug \
--with-wx=/usr/local/wxWidgets-260 \
--with-wx-config=wx-config \
--with-pgsql=/usr/local/pgsql \
--with-pgsql-include=/usr/local/pgsql/include

checking/verifying in "src/Makefile":
@279
pg_debug_build = yes

and in /.configure:
@4872
# Check whether --enable-debug or --disable-debug was given.
if test "${enable_debug+set}" = set; then
enableval="$enable_debug"
pg_debug_build=yes
CFLAGS="-Wall -g -O0"
CXXFLAGS="-Wall -g -O0"
else
pg_debug_build=no
fi;

looks ok (doesn't it?).

hmmm ... why/where is "pg_debug_build=no" NOT being set ...
do we need an EXPLICIT test for "--disable-debug" to set the NO case?

i'm gonna try this without the --disable-debug flag ...

>> --- (CASE wxwidgets-cvs) ------------------------------------------
>>
>> no longer requires a chmod on complete-bundle.sh
>>
>> configures OK
>>
>> 'make all' fails at:
>>
>> ld: Undefined symbols:
>> wxAssert(int, wchar_t const*, int, wchar_t const*, wchar_t const*)
>> make[2]: *** [pgadmin3] Error 1
>> make[1]: *** [all-recursive] Error 1
>> make: *** [all] Error 2
>>
>> i'll see what i can find out abt this one ...
> Hm... the nighty build currently link against wx-cvs (because
> 2.6 wasn't released when I set the build-daemon up), and
> it links sucessfully....
>
> Did you "make clean" your source-tree after switching wx version?

actually, i'm using two separate source trees ...

/usr/local/pgadmin3-cvs <-- linking agains wxWidgets-260
/usr/local/pgadmin3-cvs2 <-- linking agains wxWidgets-cvs

and when i don't do a clean DL, i always run a 'make distclean' (confirmed)

cheers,

richard

OpenMacNews wrote:
> hi florian,
>> Hm.. this is strange... I works for the nightly builds...
>> In src/Makefile.am, you should find the lines:
>> if test "$(pg_debug_build)" = "no"; then \
>> strip pgAdmin3 ;\
>> fi
>>
>> Could you put an "echo $(pg_debug_build)" before the if,
>> and post the output?
>
> ok. per request,
>
> @216
> mv tmp pgAdmin3 ;\
> +++ echo $(pg_debug_build) ;\
> if test "$(pg_debug_build)" = "no"; then \
> strip pgAdmin3 ;\
> fi
>
...
> here's the 'make install' output ....
> ...
> make install-exec-hook
> cd /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS ;\
> mv pgadmin3 tmp ;\
> mv tmp pgAdmin3 ;\
> echo yes ;\
> if test "yes" = "no"; then \
> strip pgAdmin3 ;\
> fi
> yes
> ...
> hmmm, $pg_debug_build is reporting as YES despite my config as:
>
> ./configure \
> --enable-appbundle \
> --enable-static \
> --disable-debug \
> --with-wx=/usr/local/wxWidgets-260 \
> --with-wx-config=wx-config \
> --with-pgsql=/usr/local/pgsql \
> --with-pgsql-include=/usr/local/pgsql/include
>
> checking/verifying in "src/Makefile":
> @279
> pg_debug_build = yes
>
> and in /.configure:
> @4872
> # Check whether --enable-debug or --disable-debug was given.
> if test "${enable_debug+set}" = set; then
> enableval="$enable_debug"
> pg_debug_build=yes
> CFLAGS="-Wall -g -O0"
> CXXFLAGS="-Wall -g -O0"
> else
> pg_debug_build=no
> fi;
Hm.. I have no idea what going on here... Is there an autoconf guru here
who might provide insight?

> hmmm ... why/where is "pg_debug_build=no" NOT being set ...
> do we need an EXPLICIT test for "--disable-debug" to set the NO case?
>
> i'm gonna try this without the --disable-debug flag ...
I just checked - the nightly builds are done with neither "--enable-debug"
nor "--disable-debug" specified, and things work correctly...

FYI, configure is autogenerated, and the snipped that checks
for the debug option is found in acinclude.m4 - but it looks
even more correct there (at least for my autoconf-unsavy eyes...)

Greetings, Florian Pflug

hi,

> Hm.. I have no idea what going on here... Is there an autoconf guru here
> who might provide insight?
>
>> hmmm ... why/where is "pg_debug_build=no" NOT being set ...
>> do we need an EXPLICIT test for "--disable-debug" to set the NO case?
>>
>> i'm gonna try this without the --disable-debug flag ...
> I just checked - the nightly builds are done with neither "--enable-debug"
> nor "--disable-debug" specified, and things work correctly...

well, i just rebuilt w/ NO debug flag in the config, i.e.:

./configure \
--enable-appbundle \
--enable-static \
--with-wx=/usr/local/wxWidgets-260 \
--with-wx-config=wx-config \
--with-pgsql=/usr/local/pgsql \
--with-pgsql-include=/usr/local/pgsql/include

NOW, the 'make install' output shows:

...
make install-exec-hook
cd /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS ;\
mv pgadmin3 tmp ;\
mv tmp pgAdmin3 ;\
echo no ;\
if test "no" = "no"; then \
strip pgAdmin3 ;\
fi
no
...

AND the executable IS properly stripped:

% ls -al /usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3
-rwxr-xr-x 1 root admin 7767372 Apr 26 10:18
/usr/ports/pgadmin3-cvs/pgAdmin3.app/Contents/MacOS/pgAdmin3

so, what we're seeing is:

"./configure --disable-debug", fails to set pg_debug_build=no, i.e. sets =
yes.

but,

"./configure" sets it correctly

> FYI, configure is autogenerated, and the snipped that checks
> for the debug option is found in acinclude.m4 - but it looks
> even more correct there (at least for my autoconf-unsavy eyes...)

looking in acinclude.m4:

###########################
# Debug build of pgAdmin3 #
###########################
AC_DEFUN([ENABLE_DEBUG],
[AC_ARG_ENABLE(debug,
[ --enable-debug build a debug version of pgAdmin3],
[pg_debug_build=yes
CFLAGS="-Wall -g -O0"
CXXFLAGS="-Wall -g -O0"],
[pg_debug_build=no])
])
AC_SUBST(pg_debug_build)

looks ok to me as well ...

ok, this has got to be something obvious/simple, but i'm missing it.

richard