Re: Why doesn't query_tree_walker examine the intoClause field?

Lists: pgsql-hackers
From: Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Why doesn't query_tree_walker examine the intoClause field?
Date: 2010-01-08 08:52:42
Message-ID: a301bfd91001080052x75dea119q7cecc7a214428bc0@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

I am kinda puzzled as to why the query_tree_walker() function does not
examine the intoClause field? I do see another function
raw_expression_tree_walker() which does walk that entry. So what is
the exact reason here? Or we just missed it for the earlier function?

Regards,
Nikhils
--
http://www.enterprisedb.com


From: Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why doesn't query_tree_walker examine the intoClause field?
Date: 2010-01-08 09:10:19
Message-ID: a301bfd91001080110m59599ec1q8b05aabecc3e850d@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Self answer: Because the post-analysis phase does not have anything
interesting to peek in it. The only interesting thing could be the
RangeVar, but it is not going to be in an RTE form after the
transformstmt, so not much point.

Sorry for the noise.

Regards,
Nikhils

On Fri, Jan 8, 2010 at 2:22 PM, Nikhil Sontakke
<nikhil(dot)sontakke(at)enterprisedb(dot)com> wrote:
> Hi,
>
> I am kinda puzzled as to why the query_tree_walker() function does not
> examine the intoClause field? I do see another function
> raw_expression_tree_walker() which does walk that entry. So what is
> the exact reason here? Or we just missed it for the earlier function?
>
> Regards,
> Nikhils
> --
> http://www.enterprisedb.com
>

--
http://www.enterprisedb.com


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why doesn't query_tree_walker examine the intoClause field?
Date: 2010-01-08 13:37:45
Message-ID: 4238.1262957865@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Nikhil Sontakke <nikhil(dot)sontakke(at)enterprisedb(dot)com> writes:
> I am kinda puzzled as to why the query_tree_walker() function does not
> examine the intoClause field?

Is there any point to it?

regards, tom lane