| Lists: | pgsql-patches |
|---|
| From: | Thomas Hallgren <thhal(at)mailblocks(dot)com> |
|---|---|
| To: | "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Fix that deals with unusable custom variables. |
| Date: | 2005-03-15 18:07:42 |
| Message-ID: | 4237246E.7030305@mailblocks.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
This is a bit embarrassing but the patch I submitted that enables custom
variable classes (8-10 months ago) was somewhat incomplete. The
DefineCustomIntVariable and DefineCustomRealVariable functions doesn't
have parameters that make it possible to set the min and max values of
the variables. Consequently, custom variables of int and real type are
completely useless. This patch adds the additional parameters minValue
and maxValue to those functions.
No one but me have used this so far (or someone would have noticed) so I
think it would be safe to backport this for 8.0.2.
Regards,
Thomas Hallgren
| Attachment | Content-Type | Size |
|---|---|---|
| gucbug.diff | text/plain | 2.1 KB |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Hallgren <thhal(at)mailblocks(dot)com> |
| Cc: | "pgsql-patches(at)postgresql(dot)org" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Fix that deals with unusable custom variables. |
| Date: | 2005-03-25 16:18:05 |
| Message-ID: | 24951.1111767485@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Thomas Hallgren <thhal(at)mailblocks(dot)com> writes:
> This is a bit embarrassing but the patch I submitted that enables custom
> variable classes (8-10 months ago) was somewhat incomplete. The
> DefineCustomIntVariable and DefineCustomRealVariable functions doesn't
> have parameters that make it possible to set the min and max values of
> the variables. Consequently, custom variables of int and real type are
> completely useless. This patch adds the additional parameters minValue
> and maxValue to those functions.
> No one but me have used this so far (or someone would have noticed) so I
> think it would be safe to backport this for 8.0.2.
Applied to HEAD and 8.0.
regards, tom lane