Re: small doccumentation fix in psql

Lists: pgsql-hackers
From: Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: small doccumentation fix in psql
Date: 2014-07-16 05:21:09
Message-ID: 4205E661176A124FAF891E0A6BA9135266343823@szxeml509-mbs.china.huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Currently \pset is supported without any argument also, so same is updated in documentation.

\pset option [ value ]
Changed to
\pset [ option [ value ] ]

Thanks & Regards,
Dilip Kumar

Attachment Content-Type Size
psql_doc.patch application/octet-stream 641 bytes

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: small doccumentation fix in psql
Date: 2014-07-21 08:09:00
Message-ID: alpine.DEB.2.02.1407211003080.15140@andorre
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


> Currently \pset is supported without any argument also, so same is updated in documentation.
>
> \pset option [ value ]
> Changed to
> \pset [ option [ value ] ]

This patch does update the documentation as stated, and make it consistent
with the reality and the embedded psql help. This is an improvement and I
recommand its inclusion.

I would also suggest to move the sentence at the end of the description:

"\pset without any arguments displays the current status of all printing
options."

At then end of the first paragraph, before the detailed description of
options, so as to comment directly on this non mandatory "option".

--
Fabien.


From: Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: small doccumentation fix in psql
Date: 2014-07-22 03:46:36
Message-ID: 4205E661176A124FAF891E0A6BA91352663452BE@szxeml509-mbs.china.huawei.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 21 July 2014 13:39, Fabien COELHO Wrote

> This patch does update the documentation as stated, and make it
> consistent with the reality and the embedded psql help. This is an
> improvement and I recommand its inclusion.
>
> I would also suggest to move the sentence at the end of the description:
>
> "\pset without any arguments displays the current status of all
> printing options."
>
> At then end of the first paragraph, before the detailed description of
> options, so as to comment directly on this non mandatory "option".
>

Done.

Regards,
Dilip

Attachment Content-Type Size
psql_doc_v1.patch application/octet-stream 1.3 KB

From: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
To: Dilip kumar <dilip(dot)kumar(at)huawei(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: small doccumentation fix in psql
Date: 2014-07-22 04:58:57
Message-ID: alpine.DEB.2.10.1407220657000.5360@sto
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


>> This patch does update the documentation as stated, and make it
>> consistent with the reality and the embedded psql help. This is an
>> improvement and I recommand its inclusion.
>>
>> I would also suggest to move the sentence at the end of the description:
>>
>> "\pset without any arguments displays the current status of all
>> printing options."
>>
>> At then end of the first paragraph, before the detailed description of
>> options, so as to comment directly on this non mandatory "option".

Indeed, the new patch implements the suggestion, and I think this is an
improvement, so I recommand its inclusion.

--
Fabien.