| Lists: | pgsql-patches |
|---|
| From: | "Dave Page" <dpage(at)vale-housing(dot)co(dot)uk> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | pg_autovacuum/Win32 Fixes |
| Date: | 2005-01-21 16:09:21 |
| Message-ID: | E7F85A1B5FF8D44C8A1AF6885BC9A0E45285B4@ratbert.vale-housing.co.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Theis patch supercedes *all* my earlier ones from today - apologies for
the noise, clearly I need a beer or 3 and a few nights away from the
laptop.
The following fixes are included:
- Dependency services may not be correctly registered when installing as
a Windows Service.
- The sleep time is changed from milliseconds to seconds as it should
be.
- Error messages during service installation/removal are logged to
stderr.
Regards, Dave.
| Attachment | Content-Type | Size |
|---|---|---|
| pg_autovacuum.c.diff | application/octet-stream | 3.1 KB |
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pg_autovacuum/Win32 Fixes |
| Date: | 2005-01-22 10:13:17 |
| Message-ID: | 41F2273D.2060502@samurai.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
Dave Page wrote:
> Theis patch supercedes *all* my earlier ones from today - apologies for
> the noise, clearly I need a beer or 3 and a few nights away from the
> laptop.
@@ -1166,7 +1166,9 @@
exit(0);
#ifdef WIN32
case 'E':
- args->service_dependencies = optarg;
+ ZeroMemory(deps, sizeof(deps));
+ snprintf(deps, sizeof(deps) - 2, "%s", optarg);
+ args->service_dependencies = (char *)deps;
break;
case 'I':
args->install_as_service++;
After googling around I can see what this code is intended to do; in the
future a comment might be nice. Also, why not strncpy()?
Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD
on Monday.
-Neil
| From: | Neil Conway <neilc(at)samurai(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)vale-housing(dot)co(dot)uk> |
| Cc: | pgsql-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: pg_autovacuum/Win32 Fixes |
| Date: | 2005-01-24 00:15:31 |
| Message-ID: | 1106525731.22946.292.camel@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-patches |
On Sat, 2005-01-22 at 21:13 +1100, Neil Conway wrote:
> Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD
> on Monday.
Applied, thanks for the patch.
-Neil