| Lists: | pgsql-www |
|---|
| From: | Omar Kilani <omar(at)tinysofa(dot)org> |
|---|---|
| To: | pgsql-www(at)postgresql(dot)org |
| Subject: | [PATCH] Language selection based on browser preference, use UTF-8, care about direction, etc |
| Date: | 2004-11-15 07:59:39 |
| Message-ID: | 419861EB.1000801@tinysofa.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
Hello,
Attached patch:
* Picks a language based on the actual browser preference.
* Makes all pages default to UTF-8.
* Adds language direction support.
* Makes pages tell the browser what language they're in.
* Fixes language_map.
* Adds a couple of extra handy language functions.
It's in place at our pgweb, but diffed against gborg. Set your browser
to 'de' (Tools -> Options -> General -> Languages, add 'German [de]' and
move it up to the top) and you'll see a german news item at the top (I
google translated it) of the homepage. Go to About/Advantages and you
should see the german version of the page from advocacy. Right-clicking
on the page and clicking 'Properties' should say "Text Language: German."
Clicking the Arabic or Hebrew on the bottom should switch the page
direction.
Omar
| Attachment | Content-Type | Size |
|---|---|---|
| pgweb-language.patch | text/plain | 5.8 KB |
| From: | Alexey Borzov <borz_off(at)cs(dot)msu(dot)su> |
|---|---|
| To: | Omar Kilani <omar(at)tinysofa(dot)org> |
| Cc: | pgsql-www(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Language selection based on browser preference, |
| Date: | 2004-11-17 10:01:20 |
| Message-ID: | 419B2170.2010109@cs.msu.su |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-www |
Hi,
Omar Kilani wrote:
> Attached patch:
>
> * Picks a language based on the actual browser preference.
> * Makes all pages default to UTF-8.
> * Adds language direction support.
> * Makes pages tell the browser what language they're in.
> * Fixes language_map.
> * Adds a couple of extra handy language functions.
I have some questions regarding the patch:
1) What's the purpose of adding the encoding to the HTML? It's already
defined in .htaccess and having it in HTML may lead to some problems.
2) All files are expected to be in UTF-8, so is there a reason to encode
Cyrillic letters in HTML entitites?
3) The language_from_accept_language() function does not seem to handle
quality values for preferred languages, as described f.e. here:
http://httpd.apache.org/docs/content-negotiation.html