Lists: | pgsql-hackers-win32 |
---|
From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-hackers-win32(at)postgresql(dot)org |
Subject: | Isn't win32_make_absolute() a waste of time? |
Date: | 2004-11-05 22:37:40 |
Message-ID: | 18457.1099694260@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers-win32 |
AFAICS, src/port/exec.c's win32_make_absolute() is never called with
a relative path. Is there a reason not to remove it (ie, does it do
something beyond what the comments claim)?
regards, tom lane
From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | pgsql-hackers-win32 <pgsql-hackers-win32(at)postgresql(dot)org> |
Subject: | Re: Isn't win32_make_absolute() a waste of |
Date: | 2004-11-05 23:39:02 |
Message-ID: | 418C0F16.3020703@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers-win32 |
At the time this was included in initdb.c, if you called initdb like
this: "bin/initdb" then the path to postgres ended up being determined
as "bin/postgres". This function was put in to get around a problem
Windows had in certain cases with such relative paths. That code path
has now changed so radically that you might be right in thinking it
redundant - I will have a closer look unless Bruce can give a
categorical answer.
cheers
andrew
Tom Lane wrote:
>AFAICS, src/port/exec.c's win32_make_absolute() is never called with
>a relative path. Is there a reason not to remove it (ie, does it do
>something beyond what the comments claim)?
>
>
>
>