Re: About pgevent

Lists: pgsql-hackers
From: "Magnus Hagander" <mha(at)sollentuna(dot)net>
To: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: About pgevent
Date: 2004-07-31 21:50:19
Message-ID: 6BCB9D8A16AC4241919521715F4D8BCE34BFAC@algol.sollentuna.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

>If pgevent is a DLL, why is it in src/bin?
>
>We cannot have binary files like MSG00001.bin in our source tree, no
>matter how convenient it is. The distributors are going to
>kill us for
>that. Please find another way.

The discussion back when it was decided weighted things back and forth.
The main thing is that we'd include an extra build dependency for win32,
which would be the Microsoft toolkit, several hundred Mb to download
just to build a 32 byte file.

What distributors would kill us for that, and why? The file is only ever
built (indeed, the whole directory is only *entered*) on win32.

//Magnus


From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: About pgevent
Date: 2004-07-31 22:12:08
Message-ID: 200408010012.08123.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Magnus Hagander wrote:
> The discussion back when it was decided weighted things back and
> forth. The main thing is that we'd include an extra build dependency
> for win32, which would be the Microsoft toolkit, several hundred Mb
> to download just to build a 32 byte file.

Think about what "open source" means. It doesn't mean that we give our
users binary blobs compiled on some guy's machine, because it's too
inconvenient to obtain the build tools. If it's too inconvenient to
obtain build tools, you use a binary distribution anyway.

On closer inspection this stuff should probably be moved to src/utils in
any case. It's clearly not a user binary, so it doesn't belong under
src/bin.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: "Magnus Hagander" <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: About pgevent
Date: 2004-08-01 00:24:58
Message-ID: 4090.1091319898@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> Think about what "open source" means. It doesn't mean that we give our
> users binary blobs compiled on some guy's machine, because it's too
> inconvenient to obtain the build tools. If it's too inconvenient to
> obtain build tools, you use a binary distribution anyway.

If I understand what the README is saying, pgmsgevent.mc is the source
file (the "preferred form for modification"), and MSG00001.bin is just
prebuilt output from it. It's unpleasant that it's not text, but I
don't see that this is fundamentally different from providing configure
along with configure.in.

regards, tom lane