Bug in translation of DEALLOCATE PREPARE

[Apologies if you see multiple of these - this is my 4th attempt to post
in 3 days.]

Hi,

I believe in recent interface changes changes in ecpg the
translation of 'DEALLOCATE PREPARE' were missed out. This worker fine
under 7.3.5.

Currently

EXEC SQL DEALLOCATE PREPARE foobar;

is translated to

{ ECPGdeallocate(__LINE__, ""foobar"");}

The double quotes are obviously wrong, but when I remove them the
compiler says that it now expects 3 arguments to ECPGdeallocate instead
of 2. I assume this is a trivial fix to ecpg, but I don't have the time
right now to try to understand what ecpg does internally. I'd really
appreciate it if somebody could tell me how/where ecpg needs to be fixed.

Cheers,

Adriaan

Michael, would you comment on this? Thanks.

---------------------------------------------------------------------------

Adriaan Joubert wrote:
>
> [Apologies if you see multiple of these - this is my 4th attempt to post
> in 3 days.]
>
> Hi,
>
> I believe in recent interface changes changes in ecpg the
> translation of 'DEALLOCATE PREPARE' were missed out. This worker fine
> under 7.3.5.
>
> Currently
>
> EXEC SQL DEALLOCATE PREPARE foobar;
>
> is translated to
>
> { ECPGdeallocate(__LINE__, ""foobar"");}
>
> The double quotes are obviously wrong, but when I remove them the
> compiler says that it now expects 3 arguments to ECPGdeallocate instead
> of 2. I assume this is a trivial fix to ecpg, but I don't have the time
> right now to try to understand what ecpg does internally. I'd really
> appreciate it if somebody could tell me how/where ecpg needs to be fixed.
>
> Cheers,
>
> Adriaan
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faqs/FAQ.html
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

On Sat, Apr 03, 2004 at 08:35:45AM +0300, Adriaan Joubert wrote:
> I believe in recent interface changes changes in ecpg the
> translation of 'DEALLOCATE PREPARE' were missed out. This worker fine
> under 7.3.5.

You're completely correct. I just committed a patch to HEAD and 7.4.

Thanks for the report.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

On Wed, May 19, 2004 at 08:33:22PM -0400, Bruce Momjian wrote:
>
> Michael, would you comment on this? Thanks.

I'm sorry for the dealy, but I'm desperately looking for some spare
time to work on ecpg. So I just crawl through my mails very slowly.

Michael
--
Michael Meskes
Email: Michael at Fam-Meskes dot De
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!