| Lists: | pgsql-hackers |
|---|
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | recovery.conf.sample |
| Date: | 2010-02-23 04:44:40 |
| Message-ID: | 3f0b79eb1002222044m26a848a7rc28b2022dc6a60df@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
recovery.conf.sample has the following section for Hot Standby.
Is this still required?
> #---------------------------------------------------------------------------
> # HOT STANDBY PARAMETERS
> #---------------------------------------------------------------------------
> #
> # If you want to enable read-only connections during recovery, enable
> # recovery_connections in postgresql.conf
> #
> #---------------------------------------------------------------------------
Heikki classified the recovery options into the following three
groups, in the document.
26.1. Archive recovery settings
26.2. Recovery target settings
26.3. Standby server settings
OTOH, recovery.conf.sample has classified them into the following
two groups. This is inconsistent with the document, and looks
confusing. How about modifying recovery.conf.sample to make the
grouping the same?
ARCHIVE RECOVERY PARAMETERS
LOG-STREAMING REPLICATION PARAMETERS
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: recovery.conf.sample |
| Date: | 2010-03-03 12:51:29 |
| Message-ID: | 3f0b79eb1003030451q50516ec0p633e069f4fac0c3d@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> recovery.conf.sample has the following section for Hot Standby.
> Is this still required?
>
>> #---------------------------------------------------------------------------
>> # HOT STANDBY PARAMETERS
>> #---------------------------------------------------------------------------
>> #
>> # If you want to enable read-only connections during recovery, enable
>> # recovery_connections in postgresql.conf
>> #
>> #---------------------------------------------------------------------------
>
>
> Heikki classified the recovery options into the following three
> groups, in the document.
>
> 26.1. Archive recovery settings
> 26.2. Recovery target settings
> 26.3. Standby server settings
>
> OTOH, recovery.conf.sample has classified them into the following
> two groups. This is inconsistent with the document, and looks
> confusing. How about modifying recovery.conf.sample to make the
> grouping the same?
>
> ARCHIVE RECOVERY PARAMETERS
> LOG-STREAMING REPLICATION PARAMETERS
The attached patch removes the unnecessary section about HS from
recovery.conf.sample. Also it changes the grouping of parameters
in recovery.conf.sample as mentioned above.
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| change_recovery_conf_sample_v1.patch | text/x-patch | 1.6 KB |
| From: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
| Subject: | Re: recovery.conf.sample |
| Date: | 2010-04-06 11:41:52 |
| Message-ID: | 1270554112.24910.5866.camel@ebony |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, 2010-03-03 at 21:51 +0900, Fujii Masao wrote:
> The attached patch removes the unnecessary section about HS from
> recovery.conf.sample. Also it changes the grouping of parameters
> in recovery.conf.sample as mentioned above.
I think that comment block is useful for people to remind them that some
relevant parameters need to be set in postgresql.conf. They might
otherwise try to put them in recovery.conf and be surprised by the
result.
--
Simon Riggs www.2ndQuadrant.com
| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: recovery.conf.sample |
| Date: | 2010-04-06 14:55:05 |
| Message-ID: | 4BBB4B49.30903@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Fujii Masao wrote:
> On Tue, Feb 23, 2010 at 1:44 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> recovery.conf.sample has the following section for Hot Standby.
>> Is this still required?
>>
>>> #---------------------------------------------------------------------------
>>> # HOT STANDBY PARAMETERS
>>> #---------------------------------------------------------------------------
>>> #
>>> # If you want to enable read-only connections during recovery, enable
>>> # recovery_connections in postgresql.conf
>>> #
>>> #---------------------------------------------------------------------------
>>
>> Heikki classified the recovery options into the following three
>> groups, in the document.
>>
>> 26.1. Archive recovery settings
>> 26.2. Recovery target settings
>> 26.3. Standby server settings
>>
>> OTOH, recovery.conf.sample has classified them into the following
>> two groups. This is inconsistent with the document, and looks
>> confusing. How about modifying recovery.conf.sample to make the
>> grouping the same?
>>
>> ARCHIVE RECOVERY PARAMETERS
>> LOG-STREAMING REPLICATION PARAMETERS
>
> The attached patch removes the unnecessary section about HS from
> recovery.conf.sample. Also it changes the grouping of parameters
> in recovery.conf.sample as mentioned above.
I committed the "LOG-STREAMING REPLICATION PARAMETERS" -> "STANDBY
SERVER PARAMETERS" rename. Simon added the "RECOVERY TARGET PARAMETERS"
heading already, and he wants to keep the Hot Standby section.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com