Re: make installcheck on non-default ports

I was trying to set up my dev box for multiple simultaneous Postgres
installs (7.3 stable, 7.4 stable, cvs head) and discovered that
`make installcheck` did not honor the default port assigned at configure
time. I view this as a bug.

The attached resolves the issue for all three versions.

Any objections to me applying this to cvs head? What about 7.3 and 7.4
stable branches?

Thanks,

Joe

Joe Conway wrote:
> I was trying to set up my dev box for multiple simultaneous Postgres
> installs (7.3 stable, 7.4 stable, cvs head) and discovered that
> `make installcheck` did not honor the default port assigned at configure
> time. I view this as a bug.
>
> The attached resolves the issue for all three versions.
>
> Any objections to me applying this to cvs head? What about 7.3 and 7.4
> stable branches?

BTW, a similar change is needed in contrib/contrib-global.mk so that
`make installcheck` will work for contrib. New patch attached.

Joe

Joe Conway <mail(at)joeconway(dot)com> writes:
> I was trying to set up my dev box for multiple simultaneous Postgres
> installs (7.3 stable, 7.4 stable, cvs head) and discovered that
> `make installcheck` did not honor the default port assigned at configure
> time. I view this as a bug.

I think there is something wrong with your setup procedures, because
I've never needed such. (I've corresponded with Joe off-list about
this --- maybe we can produce a FAQ about the right way to do it once
the dust settles.)

> Any objections to me applying this to cvs head?

AFAICS this would defeat the documented behavior of being able to set
PGHOST/PGPORT in the environment to control which postmaster "make
installcheck" will speak to. So, yeah, I think it's a bad idea.

regards, tom lane

Tom Lane wrote:
> I think there is something wrong with your setup procedures, because
> I've never needed such. (I've corresponded with Joe off-list about
> this --- maybe we can produce a FAQ about the right way to do it once
> the dust settles.)

Yup, got it.

> AFAICS this would defeat the documented behavior of being able to set
> PGHOST/PGPORT in the environment to control which postmaster "make
> installcheck" will speak to. So, yeah, I think it's a bad idea.

OK. I'll see about playing with the scripts you sent me.

Thanks,

Joe

Tom Lane wrote:
> I think there is something wrong with your setup procedures, because
> I've never needed such.

The main problem seemed to be that I had --disable-rpath in my configure
script, left over from when I was playing with options used by the RPM
spec file. Once I got rid of that, and started using a derivative of
Tom's scripts, it all started to work just fine.

Now I can do:

. pg73 (or pg74 or pg75)
cvs up
make clean
pgconfig
make all
pgctl stop
make install
pgctl start
make installcheck

I've attached the scripts in case anyone is interested.

Joe