| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | Giles Lean <giles(at)nemeton(dot)com(dot)au> |
|---|---|
| To: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
| Cc: | Marko Kreen <marko(at)l-t(dot)ee>, Peter Eisentraut <peter_e(at)gmx(dot)net>, thomas(at)pgsql(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Call for platforms |
| Date: | 2001-03-22 19:25:50 |
| Message-ID: | 25929.985289150@nemeton.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
> PS: AFAIK geometry-positive-zeros-bsd works for all NetBSD platforms - the
> above difference is only for i386 + fpu.
It doesn't on NetBSD-1.5/alpha -- there geometry-positive-zeros is
correct.
Regards,
Giles
| From: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
|---|---|
| To: | Giles Lean <giles(at)nemeton(dot)com(dot)au> |
| Cc: | Marko Kreen <marko(at)l-t(dot)ee>, Peter Eisentraut <peter_e(at)gmx(dot)net>, thomas(at)pgsql(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Call for platforms |
| Date: | 2001-03-22 19:58:04 |
| Message-ID: | 20010322195804.F22488@quartz.newn.cam.ac.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On Fri, Mar 23, 2001 at 06:25:50AM +1100, Giles Lean wrote:
>
> > PS: AFAIK geometry-positive-zeros-bsd works for all NetBSD platforms - the
> > above difference is only for i386 + fpu.
>
> It doesn't on NetBSD-1.5/alpha -- there geometry-positive-zeros is
> correct.
Sorry, that should have read:
AFAIK geometry-positive-zeros works for all NetBSD platforms - the
above difference is only for i386 + fpu.
(-bsd is for bsdi)
Thanks for the correction,
Patrick
| From: | Marko Kreen <marko(at)l-t(dot)ee> |
|---|---|
| To: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
| Cc: | Giles Lean <giles(at)nemeton(dot)com(dot)au>, Peter Eisentraut <peter_e(at)gmx(dot)net>, thomas(at)pgsql(dot)com, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Call for platforms |
| Date: | 2001-03-22 20:27:44 |
| Message-ID: | 20010322222743.A23032@l-t.ee |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On Thu, Mar 22, 2001 at 07:58:04PM +0000, Patrick Welche wrote:
> On Fri, Mar 23, 2001 at 06:25:50AM +1100, Giles Lean wrote:
> >
> > > PS: AFAIK geometry-positive-zeros-bsd works for all NetBSD platforms - the
> > > above difference is only for i386 + fpu.
> >
> > It doesn't on NetBSD-1.5/alpha -- there geometry-positive-zeros is
> > correct.
>
> Sorry, that should have read:
>
> AFAIK geometry-positive-zeros works for all NetBSD platforms - the
> above difference is only for i386 + fpu.
Seems that following patch is needed. Now It Works For Me (tm).
Giles, does the regress test now succed for you?
--
marko
Index: src/test/regress/resultmap
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/test/regress/resultmap,v
retrieving revision 1.45
diff -u -r1.45 resultmap
--- src/test/regress/resultmap 2001/03/22 15:13:18 1.45
+++ src/test/regress/resultmap 2001/03/22 17:29:49
@@ -17,6 +17,7 @@
geometry/.*-openbsd=geometry-positive-zeros-bsd
geometry/.*-irix6=geometry-irix
geometry/.*-netbsd=geometry-positive-zeros
+geometry/i.86-.*-netbsdelf1.5=geometry-positive-zeros-bsd
geometry/.*-sysv5uw7.*:cc=geometry-uw7-cc
geometry/.*-sysv5uw7.*:gcc=geometry-uw7-gcc
geometry/alpha.*-dec-osf=geometry-alpha-precision
| From: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
|---|---|
| To: | Marko Kreen <marko(at)l-t(dot)ee> |
| Cc: | Giles Lean <giles(at)nemeton(dot)com(dot)au>, Peter Eisentraut <peter_e(at)gmx(dot)net>, thomas(at)pgsql(dot)com, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Call for platforms |
| Date: | 2001-03-22 20:30:36 |
| Message-ID: | 20010322203036.H22488@quartz.newn.cam.ac.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On Thu, Mar 22, 2001 at 10:27:44PM +0200, Marko Kreen wrote:
> On Thu, Mar 22, 2001 at 07:58:04PM +0000, Patrick Welche wrote:
> >
> > AFAIK geometry-positive-zeros works for all NetBSD platforms - the
> > above difference is only for i386 + fpu.
>
> Seems that following patch is needed. Now It Works For Me (tm).
> Giles, does the regress test now succed for you?
Your patch works for me (i386) - I'd just like to point out that it's
because we are both running on peecees with fpus and thus with libm387
loaded (else works without patch)
BTW
NetBSD 2.8 alpha 7.1 2001-03-22, Giles Lean
Shouldn't that be 1.5?
Cheers,
Patrick
| From: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | psql-patches(at)postgresql(dot)org |
| Subject: | Re: Call for platforms |
| Date: | 2001-04-12 16:15:52 |
| Message-ID: | 20010412171552.A3501@quartz.newn.cam.ac.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Did we decide that "most NetBSD/i386 users have fpus" in which case Marko's
patch should be applied?
Cheers,
Patrick
(just checked, it isn't in today's cvs)
On Thu, Mar 22, 2001 at 10:27:44PM +0200, Marko Kreen wrote:
> On Thu, Mar 22, 2001 at 07:58:04PM +0000, Patrick Welche wrote:
> > On Fri, Mar 23, 2001 at 06:25:50AM +1100, Giles Lean wrote:
> > >
> > > > PS: AFAIK geometry-positive-zeros-bsd works for all NetBSD platforms - the
> > > > above difference is only for i386 + fpu.
> > >
> > > It doesn't on NetBSD-1.5/alpha -- there geometry-positive-zeros is
> > > correct.
> >
> > Sorry, that should have read:
> >
> > AFAIK geometry-positive-zeros works for all NetBSD platforms - the
> > above difference is only for i386 + fpu.
>
> Seems that following patch is needed. Now It Works For Me (tm).
> Giles, does the regress test now succed for you?
>
> --
> marko
>
>
> Index: src/test/regress/resultmap
> ===================================================================
> RCS file: /home/projects/pgsql/cvsroot/pgsql/src/test/regress/resultmap,v
> retrieving revision 1.45
> diff -u -r1.45 resultmap
> --- src/test/regress/resultmap 2001/03/22 15:13:18 1.45
> +++ src/test/regress/resultmap 2001/03/22 17:29:49
> @@ -17,6 +17,7 @@
> geometry/.*-openbsd=geometry-positive-zeros-bsd
> geometry/.*-irix6=geometry-irix
> geometry/.*-netbsd=geometry-positive-zeros
> +geometry/i.86-.*-netbsdelf1.5=geometry-positive-zeros-bsd
> geometry/.*-sysv5uw7.*:cc=geometry-uw7-cc
> geometry/.*-sysv5uw7.*:gcc=geometry-uw7-gcc
> geometry/alpha.*-dec-osf=geometry-alpha-precision
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Don't 'kill -9' the postmaster
| From: | Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu> |
|---|---|
| To: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, psql-patches(at)postgresql(dot)org |
| Subject: | Re: Call for platforms |
| Date: | 2001-04-13 13:25:45 |
| Message-ID: | 3AD6FE59.2A002747@alumni.caltech.edu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
> Did we decide that "most NetBSD/i386 users have fpus" in which case Marko's
> patch should be applied?
I'm unclear on what y'all mean by "i386 + fpu", especially since NetBSD
seems to insist on calling every Intel processor a "i386". In this case,
are you suggesting that this patch covers all NetBSD installations on
every Intel processor from i386 + fpu forward to i486, i586, etc etc? Or
is this specifically for the i386 with the 80387 coprocessor which is
how any reasonable person would interpret "i386+fpu"? ;)
- Thomas
> > Index: src/test/regress/resultmap
> > ===================================================================
> > RCS file: /home/projects/pgsql/cvsroot/pgsql/src/test/regress/resultmap,v
> > retrieving revision 1.45
> > diff -u -r1.45 resultmap
> > --- src/test/regress/resultmap 2001/03/22 15:13:18 1.45
> > +++ src/test/regress/resultmap 2001/03/22 17:29:49
> > @@ -17,6 +17,7 @@
> > geometry/.*-openbsd=geometry-positive-zeros-bsd
> > geometry/.*-irix6=geometry-irix
> > geometry/.*-netbsd=geometry-positive-zeros
> > +geometry/i.86-.*-netbsdelf1.5=geometry-positive-zeros-bsd
> > geometry/.*-sysv5uw7.*:cc=geometry-uw7-cc
> > geometry/.*-sysv5uw7.*:gcc=geometry-uw7-gcc
> > geometry/alpha.*-dec-osf=geometry-alpha-precision
| From: | Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> |
|---|---|
| To: | lockhart(at)fourpalms(dot)org |
| Cc: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Call for platforms |
| Date: | 2001-04-13 16:48:51 |
| Message-ID: | 20010413174851.A2330@quartz.newn.cam.ac.uk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
On Fri, Apr 13, 2001 at 01:25:45PM +0000, Thomas Lockhart wrote:
> > Did we decide that "most NetBSD/i386 users have fpus" in which case Marko's
> > patch should be applied?
>
> I'm unclear on what y'all mean by "i386 + fpu", especially since NetBSD
> seems to insist on calling every Intel processor a "i386".
History ;-)
> In this case,
> are you suggesting that this patch covers all NetBSD installations on
> every Intel processor from i386 + fpu forward to i486, i586, etc etc?
Yes! It's simply, if the peecee type thing has a fpu (as in the sysctl
machdep.fpu_present returns 1), then libm387.so is used, and you get
differences in the (from memory 44th insignificant figure?) otherwise it
just uses libm.so and you get what is currently correct in resultmap.
Cheers,
Patrick