Re: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64)

Subject: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64)

Hello,

The attached patch provides a test-and-set routine for PostgreSQL for HP-UX
11iV2 for the Intel Itanium architecture (known to the PostgreSQL code as
IA-64). There are actually two issues:

1. There is currently no tas (test-and-set) routine for HP-UX IA-64 in the
s_lock.h header file.
2. In HP-UX IA-64, the suffix of shared libraries is ".so", but PostgreSQL
generates a ".sl" suffix.

The attached patch fixes both issues. The bug template (also attached)
contains the details.

We (ViSolve) are a group that works closely with HP on their OpenSource
initiative. We would really appreciate a timely inclusion of this patch
into mainstream PostgreSQL.

thanks
ViSolve OpenSource Team (for HP)

I am unable to get this patch to compile:

gcc version : gcc (GCC) 3.2 20020329 (experimental)
uname -srm : HP-UX B.11.22 ia64

tar xvf postgresql-7.3.4.tar
cd postgresql-7.3.4
patch -p0 ../PostgreSQL-7.3.4_hpux3_11iv2_IA-64.patch

./configure
[snip]

make
[snip]

gmake[4]: Entering directory
`/home/postgres/src/postgresql-7.3.4/src/backend/ac
cess/transam'
gcc -O2 -Wall -Wmissing-prototypes -Wmissing-declarations
-I../../../../src/incl
ude -c -o xlog.o xlog.c
xlog.c: In function `XLogInsert':
xlog.c:641: incompatible types in assignment
xlog.c:870: incompatible types in assignment
xlog.c: In function `AdvanceXLInsertBuffer':
xlog.c:929: incompatible types in assignment
xlog.c: In function `XLogWrite':
xlog.c:1189: incompatible types in assignment
xlog.c: In function `XLogFlush':
xlog.c:1248: incompatible types in assignment
xlog.c: In function `XLOGShmemInit':
xlog.c:2361: incompatible types in assignment
xlog.c: In function `GetRedoRecPtr':
xlog.c:2918: incompatible types in assignment
xlog.c: In function `CreateCheckPoint':
xlog.c:3068: incompatible types in assignment
gmake[4]: *** [xlog.o] Error 1
gmake[4]: Leaving directory
`/home/postgres/src/postgresql-7.3.4/src/backend/acc
ess/transam'
gmake[3]: *** [transam-recursive] Error 2

This seems to be a problem with SpinLockRelease_NoHoldoff.

On Fri, 2003-10-24 at 11:51, ViSolve Open Source Team wrote:
> Subject: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64)
>
>
> Hello,
>
> The attached patch provides a test-and-set routine for PostgreSQL for HP-UX
> 11iV2 for the Intel Itanium architecture (known to the PostgreSQL code as
> IA-64). There are actually two issues:
>
> 1. There is currently no tas (test-and-set) routine for HP-UX IA-64 in the
> s_lock.h header file.
> 2. In HP-UX IA-64, the suffix of shared libraries is ".so", but PostgreSQL
> generates a ".sl" suffix.
>
> The attached patch fixes both issues. The bug template (also attached)
> contains the details.
>
> We (ViSolve) are a group that works closely with HP on their OpenSource
> initiative. We would really appreciate a timely inclusion of this patch
> into mainstream PostgreSQL.
>
> thanks
> ViSolve OpenSource Team (for HP)
>
> ______________________________________________________________________
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

Download current CVS and try that, or 7.4beta5.

---------------------------------------------------------------------------

ViSolve Open Source Team wrote:
> Subject: PostgreSQL Patch: Test-and-set routine for HP-UX (IA-64)
>
>
> Hello,
>
> The attached patch provides a test-and-set routine for PostgreSQL for HP-UX
> 11iV2 for the Intel Itanium architecture (known to the PostgreSQL code as
> IA-64). There are actually two issues:
>
> 1. There is currently no tas (test-and-set) routine for HP-UX IA-64 in the
> s_lock.h header file.
> 2. In HP-UX IA-64, the suffix of shared libraries is ".so", but PostgreSQL
> generates a ".sl" suffix.
>
> The attached patch fixes both issues. The bug template (also attached)
> contains the details.
>
> We (ViSolve) are a group that works closely with HP on their OpenSource
> initiative. We would really appreciate a timely inclusion of this patch
> into mainstream PostgreSQL.
>
> thanks
> ViSolve OpenSource Team (for HP)

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

"ViSolve Open Source Team" <opensrc_support_hp(at)visolve(dot)com> writes:
> There are actually two issues:

> 1. There is currently no tas (test-and-set) routine for HP-UX IA-64 in the
> s_lock.h header file.
> 2. In HP-UX IA-64, the suffix of shared libraries is ".so", but PostgreSQL
> generates a ".sl" suffix.

> The attached patch fixes both issues.

The patch appears to do much more than that, including unspecified
hacking in genbki.sh, random alterations of the platform-specific
s_lock.h code for platforms other than HPUX, and I'm not sure what else.
Please try again. Also, we'd rather have a patch against CVS tip
(7.4beta5 or later).

regards, tom lane