| Lists: | pgadmin-hackers |
|---|
| From: | Kris Jurka <books(at)ejurka(dot)com> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | configure --with-wx-version=2.6 should error earlier |
| Date: | 2007-05-31 19:29:11 |
| Message-ID: | Pine.BSO.4.64.0705311527100.23516@leary.csoft.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
Running configure --with-wx-version=2.6 succeeds and then bails out during
the build process. If pgadmin requires 2.8 it should enforce that at
configure time.
Kris Jurka
| From: | Dave Page <dpage(at)postgresql(dot)org> |
|---|---|
| To: | Kris Jurka <books(at)ejurka(dot)com> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: configure --with-wx-version=2.6 should error earlier |
| Date: | 2007-06-01 10:14:58 |
| Message-ID: | 465FF1A2.7020602@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
Kris Jurka wrote:
>
> Running configure --with-wx-version=2.6 succeeds and then bails out
> during the build process. If pgadmin requires 2.8 it should enforce
> that at configure time.
Agreed - configure check committed to SVN.
Thanks for the report.
Regards Dave.
| From: | Leszek Trenkner <olaf(at)post(dot)pl> |
|---|---|
| To: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: configure --with-wx-version=2.6 should error earlier |
| Date: | 2007-06-02 00:09:55 |
| Message-ID: | 32e14$4660b555$594f32e2$27817@news.chello.pl |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
Dave Page wrote:
> Kris Jurka wrote:
>>
>> Running configure --with-wx-version=2.6 succeeds and then bails out
>> during the build process. If pgadmin requires 2.8 it should enforce
>> that at configure time.
>
> Agreed - configure check committed to SVN.
>
That broke build process (you couldn't even force specific version) on
Ubuntu Fiesty (and possibly Debian), as one can have more than one
wx-widgets version installed and default wouldn't be necessary the best
one.
In fact, Ubuntu Fiesty defaults to 2.6.x, and so the check used
in ./configure (wx-config --version) gives 2.6.3, where
(wx-config --version=2.8 --version) gives 2.8.1.
So I created really ugly patch (as am really I not into shell scripting, nor
m4 macros), to fix it, but it might not work with non-debian wx-config
versions, so please doublecheck/improve (strongly recommended ! :-).
Well, in fact all major-minor version checking magic might be probably
thrown away, as we are asking wx-config for specific versions anyway.
Ugly (but works-for-me) patch attached.
| Attachment | Content-Type | Size |
|---|---|---|
| acinclude.m4.patch | text/x-diff | 1.7 KB |
| From: | Dave Page <dpage(at)postgresql(dot)org> |
|---|---|
| To: | Leszek Trenkner <olaf(at)post(dot)pl> |
| Cc: | pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: configure --with-wx-version=2.6 should error earlier |
| Date: | 2007-06-04 08:57:01 |
| Message-ID: | 4663D3DD.9030803@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgadmin-hackers |
Leszek Trenkner wrote:
> Dave Page wrote:
>
>> Kris Jurka wrote:
>>> Running configure --with-wx-version=2.6 succeeds and then bails out
>>> during the build process. If pgadmin requires 2.8 it should enforce
>>> that at configure time.
>> Agreed - configure check committed to SVN.
>>
> That broke build process (you couldn't even force specific version) on
> Ubuntu Fiesty (and possibly Debian), as one can have more than one
> wx-widgets version installed and default wouldn't be necessary the best
> one.
Whoops. Sorry. I've committed a fix for this - please test. It helps
that you can do:
wx-config --version --version=2.8
which will return the full version number for the 2.8 installation.
Thanks, Dave.