Re: Minor improvements to sslinfo contrib module

Lists: pgsql-hackers
From: Gurjeet Singh <gurjeet(at)singh(dot)im>
To: PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Minor improvements to sslinfo contrib module
Date: 2014-01-17 17:44:43
Message-ID: CABwTF4WifqSzj=qbzPPXKXGru0iinReebSoK6d5XyhioRGM6uw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Please find attached the patch that fixes a couple of comments, and adds
'static' qualifier to functions that are not used anywhere else in the code
base.

Best regards,
--
Gurjeet Singh http://gurjeet.singh.im/

EDB www.EnterpriseDB.com <http://www.enterprisedb.com>

Attachment Content-Type Size
sslinfo.patch text/x-diff 1.2 KB
From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor improvements to sslinfo contrib module
Date: 2014-01-18 02:01:01
Message-ID: 31498.1390010461@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Gurjeet Singh <gurjeet(at)singh(dot)im> writes:
> Please find attached the patch that fixes a couple of comments, and adds
> 'static' qualifier to functions that are not used anywhere else in the code
> base.

Committed, with the trivial fix that the function definitions have to be
marked static too. (gcc doesn't complain about this, which I think may be
correct per C standard; but some other compilers do whine about that sort
of inconsistency.)

regards, tom lane