| Lists: | pgsql-hackerspgsql-patches |
|---|
| From: | "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
|---|---|
| To: | <pgsql-patches(at)postgresql(dot)org> |
| Subject: | c.h is the problem of msvc. |
| Date: | 2006-07-14 16:54:57 |
| Message-ID: | 015001c6a766$3cd80290$0801a8c0@IBMC4B5932F74B |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Hi Bruce-san.
Umm, c.h is the problem of msvc.
getaddrinfo.c
..\..\include\c.h(63) : fatal error C1083: 'crtdefs.h': No such file or directory
<crtdefs.h> does not exist in vs2003...
problem is solved by removing this before vs2005.
moreover, nothing does not run short by it.
Regards,
Hiroshi Saito
| Attachment | Content-Type | Size |
|---|---|---|
| msvc_c_patch | application/octet-stream | 299 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
| Subject: | Re: [PATCHES] c.h is the problem of msvc. |
| Date: | 2006-07-14 17:35:25 |
| Message-ID: | 2945.1152898525@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
"Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
> +++ src/include/c.h Sat Jul 15 01:40:04 2006
> @@ -60,7 +60,9 @@
> #if defined(_MSC_VER) || defined(__BORLANDC__)
> #define WIN32_ONLY_COMPILER
> #define errcode __vc_errcode
> +#if (_MSC_VER > 1400)
> #include <crtdefs.h>
> +#endif
> #undef errcode
> #endif
>
This patch certainly looks like it will break the __BORLANDC__ build ...
regards, tom lane
| From: | "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
|---|---|
| To: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] c.h is the problem of msvc. |
| Date: | 2006-07-14 22:37:01 |
| Message-ID: | 022401c6a796$06689cd0$0801a8c0@IBMC4B5932F74B |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Ooops,
I am uncertain at the reason for not knowing __BORLANDC__...
It will be sure if __BORLANDC__ has the definition.
Thanks.
Regards,
Hiroshi Saito
From: "Tom Lane"
> "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
>> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
>> +++ src/include/c.h Sat Jul 15 01:40:04 2006
>> @@ -60,7 +60,9 @@
>> #if defined(_MSC_VER) || defined(__BORLANDC__)
>> #define WIN32_ONLY_COMPILER
>> #define errcode __vc_errcode
>> +#if (_MSC_VER > 1400)
>> #include <crtdefs.h>
>> +#endif
>> #undef errcode
>> #endif
>>
>
> This patch certainly looks like it will break the __BORLANDC__ build ...
>
> regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| msvc_c_patch | application/octet-stream | 324 bytes |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] c.h is the problem of msvc. |
| Date: | 2006-07-29 17:30:42 |
| Message-ID: | 200607291730.k6THUg926991@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Patch applied. Thanks.
---------------------------------------------------------------------------
Hiroshi Saito wrote:
> Ooops,
> I am uncertain at the reason for not knowing __BORLANDC__...
> It will be sure if __BORLANDC__ has the definition.
> Thanks.
>
> Regards,
> Hiroshi Saito
>
> From: "Tom Lane"
>
>
> > "Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> >> --- src/include/c.h.orig Sat Jul 15 01:38:59 2006
> >> +++ src/include/c.h Sat Jul 15 01:40:04 2006
> >> @@ -60,7 +60,9 @@
> >> #if defined(_MSC_VER) || defined(__BORLANDC__)
> >> #define WIN32_ONLY_COMPILER
> >> #define errcode __vc_errcode
> >> +#if (_MSC_VER > 1400)
> >> #include <crtdefs.h>
> >> +#endif
> >> #undef errcode
> >> #endif
> >>
> >
> > This patch certainly looks like it will break the __BORLANDC__ build ...
> >
> > regards, tom lane
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] c.h is the problem of msvc. |
| Date: | 2006-07-29 17:33:58 |
| Message-ID: | 200607291733.k6THXx104426@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers pgsql-patches |
Clarification, the attached version with the BORLAND adjustment is the
one that was applied.
---------------------------------------------------------------------------
Bruce Momjian wrote:
>
> Patch applied. Thanks.
>
> ---------------------------------------------------------------------------
>
>
> Hiroshi Saito wrote:
> > Ooops,
> > I am uncertain at the reason for not knowing __BORLANDC__...
> > It will be sure if __BORLANDC__ has the definition.
> > Thanks.
--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| unknown_filename | text/plain | 324 bytes |