| Lists: | pgsql-hackers |
|---|
| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | reindex of toast tables |
| Date: | 2002-09-02 20:07:08 |
| Message-ID: | 200209022007.g82K78e04990@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom, when you loosened the restriction on reindexing toast tables, did
you continue to restrict indexing of system tables to the superuser? Is
that required?
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: reindex of toast tables |
| Date: | 2002-09-02 20:29:45 |
| Message-ID: | 26132.1030998585@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Tom, when you loosened the restriction on reindexing toast tables, did
> you continue to restrict indexing of system tables to the superuser? Is
> that required?
Hm. Now that I look at it, the forms REINDEX TABLE and REINDEX INDEX
don't seem to have any permissions checks at all :-(. One would think
that they need to require ownership rights on the target table.
regards, tom lane
| From: | Alvaro Herrera <alvherre(at)atentus(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: reindex of toast tables |
| Date: | 2002-09-02 20:37:55 |
| Message-ID: | Pine.LNX.4.44.0209021637050.10442-100000@cm-lcon1-46-187.cm.vtr.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Tom Lane dijo:
> Hm. Now that I look at it, the forms REINDEX TABLE and REINDEX INDEX
> don't seem to have any permissions checks at all :-(. One would think
> that they need to require ownership rights on the target table.
They are done in tcop/utility.c AFAICS.
--
Alvaro Herrera (<alvherre[a]atentus.com>)
"Cuando mañana llegue pelearemos segun lo que mañana exija" (Mowgli)
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)atentus(dot)com> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: reindex of toast tables |
| Date: | 2002-09-02 23:50:56 |
| Message-ID: | 28598.1031010656@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> Tom Lane dijo:
>> Hm. Now that I look at it, the forms REINDEX TABLE and REINDEX INDEX
>> don't seem to have any permissions checks at all :-(. One would think
>> that they need to require ownership rights on the target table.
> They are done in tcop/utility.c AFAICS.
Oh, right. I was just looking at the catalog/index routines. Nevermind...
regards, tom lane