| Lists: | pgsql-bugs |
|---|
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | pgsql-bugs(at)postgresql(dot)org |
| Cc: | Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-23 17:56:03 |
| Message-ID: | 4C224AB3.6060008@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Severity: minor
Tested On: 9.0b2, 8.4.4
Platform: SUN SPARC 4u Enterprise 450 Quad, presumably Solaris 10
Repeatable? Yes
Description:
See thread:
http://archives.postgresql.org/pgsql-testers/2010-06/msg00020.php
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | Re: local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-23 18:40:28 |
| Message-ID: | 25917.1277318428@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Josh Berkus <josh(at)agliodbs(dot)com> writes:
> http://archives.postgresql.org/pgsql-testers/2010-06/msg00020.php
We'd need to see exactly how local_preload_libraries is being set.
regards, tom lane
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | Re: local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-23 21:09:59 |
| Message-ID: | 28189.1277327399@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Josh Berkus <josh(at)agliodbs(dot)com> writes:
> http://archives.postgresql.org/pgsql-testers/2010-06/msg00020.php
OK, I looked at this a bit, and the answer is that load_libraries uses
SplitIdentifierString, ie, it thinks the value of the variable is a list
of comma-separated SQL identifiers. So if you want a
filename containing upper case, whitespace, or commas, double-quote it.
That might seem a bit bizarre, but because of the special meaning of
commas we'd need some quoting rule anyhow. I'm not sure it's worth
making local_preload_libraries have its own private parsing convention.
Perhaps this is just a documentation deficiency.
regards, tom lane
| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | Re: local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-23 21:22:18 |
| Message-ID: | 4C227B0A.204@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
> That might seem a bit bizarre, but because of the special meaning of
> commas we'd need some quoting rule anyhow. I'm not sure it's worth
> making local_preload_libraries have its own private parsing convention.
> Perhaps this is just a documentation deficiency.
Yes, I'd say that documentation is the answer, given. Hmmm .... are
double-quotes respected in postgresql.conf, though? Need testing.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | pgsql-bugs(at)postgresql(dot)org, Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | Re: local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-23 21:24:50 |
| Message-ID: | 28449.1277328290@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Josh Berkus <josh(at)agliodbs(dot)com> writes:
> Yes, I'd say that documentation is the answer, given. Hmmm .... are
> double-quotes respected in postgresql.conf, though? Need testing.
Not sure. Something like
local_preload_libraries = '"Foo", "Bar"'
will definitely work. Don't know if you can dispense with the outer
single quotes.
regards, tom lane
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-bugs(at)postgresql(dot)org, Lou Picciano <loupicciano(at)comcast(dot)net> |
| Subject: | Re: local_preload_libraries filenames converted to lowercase |
| Date: | 2010-06-29 22:24:25 |
| Message-ID: | 201006292224.o5TMOP520743@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-bugs |
Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
> > Yes, I'd say that documentation is the answer, given. Hmmm .... are
> > double-quotes respected in postgresql.conf, though? Need testing.
>
> Not sure. Something like
>
> local_preload_libraries = '"Foo", "Bar"'
>
> will definitely work. Don't know if you can dispense with the outer
> single quotes.
I have documented the requirement for double quotes; attached patch
applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ None of us is going to be here forever. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 1.5 KB |