Re: Resolving pg_standby -l

Short patch to
1. disable pg_standby -l
One line change only appropriate for this stage of release
2. Remove mention of -l and link from docs

pg_standby -l is still accepted, just does nothing (for now).

Existing code maintained in case we backpatch a fix for linking problem
at a later date.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

Simon Riggs wrote:
> Short patch to
> 1. disable pg_standby -l
> One line change only appropriate for this stage of release
> 2. Remove mention of -l and link from docs
>
> pg_standby -l is still accepted, just does nothing (for now).
>
> Existing code maintained in case we backpatch a fix for linking problem
> at a later date.

Ah, I had forgotten about this already.

Committed. The patch looks very safe to me, but given that we're just
about to wrap the release I'm keeping my fingers crossed that this
didn't break anything,.

I didn't commit this to the back-branches yet, because I'm not sure if
we have consensus on that. If symlinking has a meaningful performance
advantage, someone might be unhappy if we disable that option in a minor
release. I think we should go ahead anyway, but does anyone object?

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> --- 610,621 ----
> }
> break;
> case 'l': /* Use link */
> ! /*
> ! * Link feature disabled, possibly permanently. Linking
> ! * causes a problem after recovery ends that is not currently
> ! * resolved by PostgreSQL. 25 Jun 2009
> ! restoreCommandType = RESTORE_COMMAND_LINK;
> ! */
> break;
> case 'r': /* Retries */
> maxretries = atoi(optarg);

Just for future reference: the above is going to look like hell after
pgindent gets its hands on it. Better style for this project is

/*
* ordinary comment block
*/
#ifdef NOT_USED
code to be disabled
#endif

regards, tom lane

On Thu, 2009-06-25 at 09:51 -0400, Tom Lane wrote:
> Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> > --- 610,621 ----
> > }
> > break;
> > case 'l': /* Use link */
> > ! /*
> > ! * Link feature disabled, possibly permanently. Linking
> > ! * causes a problem after recovery ends that is not currently
> > ! * resolved by PostgreSQL. 25 Jun 2009
> > ! restoreCommandType = RESTORE_COMMAND_LINK;
> > ! */
> > break;
> > case 'r': /* Retries */
> > maxretries = atoi(optarg);
>
> Just for future reference: the above is going to look like hell after
> pgindent gets its hands on it. Better style for this project is
>
> /*
> * ordinary comment block
> */
> #ifdef NOT_USED
> code to be disabled
> #endif

Will do, thanks. Patch to cleanup as advised is attached.

--
Simon Riggs www.2ndQuadrant.com
PostgreSQL Training, Services and Support

Simon Riggs <simon(at)2ndQuadrant(dot)com> writes:
> Will do, thanks. Patch to cleanup as advised is attached.

Applied, thanks.

regards, tom lane