Re: savepoints and upgrading locks

Lists: pgsql-hackers
From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: savepoints and upgrading locks
Date: 2007-05-08 20:41:49
Message-ID: 1178656909.24902.40.camel@dogma.v10.wvs
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


This thread here became a TODO item:

http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php

During that discussion a patch was produced that nobody seemed to have
objections to. The main problem seemed to be that it wouldn't always
downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
seem like a problem to me.

Is there a reason this isn't a part of 8.3, or was it just forgotten?

Regards,
Jeff Davis


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: savepoints and upgrading locks
Date: 2007-05-17 15:15:50
Message-ID: 200705171515.l4HFFoi03888@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Your patch has been added to the PostgreSQL unapplied patches list at:

http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------

Jeff Davis wrote:
>
> This thread here became a TODO item:
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
>
> During that discussion a patch was produced that nobody seemed to have
> objections to. The main problem seemed to be that it wouldn't always
> downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
> seem like a problem to me.
>
> Is there a reason this isn't a part of 8.3, or was it just forgotten?
>
> Regards,
> Jeff Davis
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 4: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +


From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: savepoints and upgrading locks
Date: 2007-05-17 15:37:19
Message-ID: 20070517153719.GE28701@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian wrote:
>
> Your patch has been added to the PostgreSQL unapplied patches list at:
>
> http://momjian.postgresql.org/cgi-bin/pgpatches
>
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.

Wait a minute. Would the mentioned patch be this one?
http://article.gmane.org/gmane.comp.db.postgresql.devel.general/73330

Because it was later declared not working; see
http://article.gmane.org/gmane.comp.db.postgresql.devel.general/73334

> Jeff Davis wrote:
> >
> > This thread here became a TODO item:
> >
> > http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
> >
> > During that discussion a patch was produced that nobody seemed to have
> > objections to. The main problem seemed to be that it wouldn't always
> > downgrade the lock on a ROLLBACK TO (as I understand it), which doesn't
> > seem like a problem to me.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: savepoints and upgrading locks
Date: 2007-05-17 15:48:22
Message-ID: 27320.1179416902@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Your patch has been added to the PostgreSQL unapplied patches list at:

Please take it off again.

> Jeff Davis wrote:
>> This thread here became a TODO item:
>> http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
>>
>> During that discussion a patch was produced that nobody seemed to have
>> objections to.

Apparently you stopped reading somewhere. It was pretty thoroughly
destroyed beginning here:
http://archives.postgresql.org/pgsql-hackers/2006-12/msg00025.php

We should have spent more effort trying to think of a solution to the
problem during the 8.3 development cycle. At the moment we're no
further ahead than we were in December.

regards, tom lane


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: savepoints and upgrading locks
Date: 2007-05-17 16:09:55
Message-ID: 200705171609.l4HG9tt17033@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


OK, emails moved to 8.4 queue.

---------------------------------------------------------------------------

Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Your patch has been added to the PostgreSQL unapplied patches list at:
>
> Please take it off again.
>
> > Jeff Davis wrote:
> >> This thread here became a TODO item:
> >> http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
> >>
> >> During that discussion a patch was produced that nobody seemed to have
> >> objections to.
>
> Apparently you stopped reading somewhere. It was pretty thoroughly
> destroyed beginning here:
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg00025.php
>
> We should have spent more effort trying to think of a solution to the
> problem during the 8.3 development cycle. At the moment we're no
> further ahead than we were in December.
>
> regards, tom lane
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +