| Lists: | pgsql-hackers |
|---|
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Ignore src/tools/msvc/config.pl in code tree for MSVC compilation |
| Date: | 2014-05-12 06:08:06 |
| Message-ID: | CAB7nPqT69ftezbJUAYw91KVKby6u9AKrf9AgVv0fjVa1Mc_tOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi all,
MSVC build uses two configuration perl files when running:
config_default.pl and config.pl. The former is mandatory and is
present in the code tree, while the latter can be used to override
settings with some custom parameters. As far as I understand from the
docs, config.pl should be used only in a custom environment and should
never be committed. Hence, why not adding a .gitignore in
src/tools/msvc and ignoring this file? This will prevent unfortunate
commits that could include this file and impact the devs working on
Windows. The patch attached does that. I think that it should be
back-patched for consistency across branches..
Regards,
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Ignore-config.pl-in-src-tools-msvc.patch | text/plain | 678 bytes |
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ignore src/tools/msvc/config.pl in code tree for MSVC compilation |
| Date: | 2014-05-12 07:07:25 |
| Message-ID: | CAB7nPqTFrhK_7ZY=Q1f__333K630d-zAT2TkBUzHUSEogxVqQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mon, May 12, 2014 at 3:08 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Hi all,
>
> MSVC build uses two configuration perl files when running:
> config_default.pl and config.pl. The former is mandatory and is
> present in the code tree, while the latter can be used to override
> settings with some custom parameters. As far as I understand from the
> docs, config.pl should be used only in a custom environment and should
> never be committed. Hence, why not adding a .gitignore in
> src/tools/msvc and ignoring this file? This will prevent unfortunate
> commits that could include this file and impact the devs working on
> Windows. The patch attached does that. I think that it should be
> back-patched for consistency across branches..
Actually I am sending an updated patch as buildenv.pl enters in the
same category as config.pl.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Ignore-config-and-buildenv-in-src-tools-msvc.patch | text/plain | 725 bytes |
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ignore src/tools/msvc/config.pl in code tree for MSVC compilation |
| Date: | 2014-05-12 18:16:14 |
| Message-ID: | 26781.1399918574@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> Actually I am sending an updated patch as buildenv.pl enters in the
> same category as config.pl.
This seems sane to me; it's in the same category as src/Makefile.custom,
which we have a .gitignore entry for. I wondered whether there were any
more such files, but the documentation at least doesn't mention any.
regards, tom lane
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Ignore src/tools/msvc/config.pl in code tree for MSVC compilation |
| Date: | 2014-05-12 23:06:01 |
| Message-ID: | CAB7nPqTJDhFy9sixoR4R=HFCGL4Ou8updLvTk-=8mEtSyNsAjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Tue, May 13, 2014 at 3:16 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> Actually I am sending an updated patch as buildenv.pl enters in the
>> same category as config.pl.
>
> This seems sane to me; it's in the same category as src/Makefile.custom,
> which we have a .gitignore entry for. I wondered whether there were any
> more such files, but the documentation at least doesn't mention any.
Maybe there are but nobody really noticed. I actually bumped into
those ones by looking at the documentation and the scripts.
--
Michael