Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL

Log Message:
-----------
sslinfo contrib module - information about current SSL certificate
Author: Victor Wagner <vitus(at)cryptocom(dot)ru>

Modified Files:
--------------
pgsql/contrib:
Makefile (r1.66 -> r1.67)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/Makefile.diff?r1=1.66&r2=1.67)
pgsql/src/include:
miscadmin.h (r1.188 -> r1.189)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/miscadmin.h.diff?r1=1.188&r2=1.189)

Added Files:
-----------
pgsql/contrib/sslinfo:
Makefile (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/sslinfo/Makefile?rev=1.1&content-type=text/x-cvsweb-markup)
README.sslinfo (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/sslinfo/README.sslinfo?rev=1.1&content-type=text/x-cvsweb-markup)
sslinfo.c (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/sslinfo/sslinfo.c?rev=1.1&content-type=text/x-cvsweb-markup)
sslinfo.sql.in (r1.1)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/contrib/sslinfo/sslinfo.sql.in?rev=1.1&content-type=text/x-cvsweb-markup)

petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> sslinfo contrib module - information about current SSL certificate
> Author: Victor Wagner <vitus(at)cryptocom(dot)ru>

It was premature to add this: Bruce is still trying to get a copyright
assignment out of the author.

regards, tom lane

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > sslinfo contrib module - information about current SSL certificate
> > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
>
> It was premature to add this: Bruce is still trying to get a
> copyright assignment out of the author.

Another one of those things that was not evident from the patch queue.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > sslinfo contrib module - information about current SSL certificate
> > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
>
> It was premature to add this: Bruce is still trying to get a copyright
> assignment out of the author.

I got it this morning. The text they sent was:

> > The copyright has to be removed so it can be copyrighted by the
> > PostgreSQL Global Development Group. Is that OK? We can still keep
> > your name and company at the top.
>
> Yes, it can be removed. I just wasn't aware that copyright transfer is
> neccessary. Most open-source projects don't have such a requirement, and
> individual portions of code are copyrighted by their respecitve authors.

Thanks.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Tom Lane wrote:
> > petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > > sslinfo contrib module - information about current SSL certificate
> > > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
> >
> > It was premature to add this: Bruce is still trying to get a copyright
> > assignment out of the author.
>
> I got it this morning. The text they sent was:
>
> > > The copyright has to be removed so it can be copyrighted by the
> > > PostgreSQL Global Development Group. Is that OK? We can still keep
> > > your name and company at the top.
> >
> > Yes, it can be removed. I just wasn't aware that copyright transfer is
> > neccessary. Most open-source projects don't have such a requirement, and
> > individual portions of code are copyrighted by their respecitve authors.

I still don't understand why is the copyright "assignment" needed at
all. Is it even valid, given that the PGDG does not have a written/
signed document? At least the FSF requires you to given them a written
and signed statement to that effect. And if it's not valid, why bother
doing it at all?

Also, the code is released under BSD license, so why is it important if
it says "Copyright Foo, Inc" or something else? We will be able to use
it regardless of the copyright assignment, as will anyone else.

One point may be that if PGDG doesn't have a "Copyright" line in the
header, it can't then automatically increment the year in there when the
time comes. Does this have anything to do with it? It may also have to
do with when someone from PGDG fixes a bug in that code.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> Also, the code is released under BSD license, so why is it important if
> it says "Copyright Foo, Inc" or something else?

Because every so often we get pestered by lawyers who get worried when
there's a collection of random different copyright notices in the code.

Actually, I don't think there's anything wrong with "Copyright Foo Inc"
as long as there's also a statement "Released under the PostgreSQL
license" or equivalent. The problem here was that with neither that nor
a "copyright assignment", there is no clear intent to make the code
available under our license terms.

regards, tom lane

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> > > petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > > > sslinfo contrib module - information about current SSL certificate
> > > > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
> > >
> > > It was premature to add this: Bruce is still trying to get a copyright
> > > assignment out of the author.
> >
> > I got it this morning. The text they sent was:
> >
> > > > The copyright has to be removed so it can be copyrighted by the
> > > > PostgreSQL Global Development Group. Is that OK? We can still keep
> > > > your name and company at the top.
> > >
> > > Yes, it can be removed. I just wasn't aware that copyright transfer is
> > > neccessary. Most open-source projects don't have such a requirement, and
> > > individual portions of code are copyrighted by their respecitve authors.
>
> I still don't understand why is the copyright "assignment" needed at
> all. Is it even valid, given that the PGDG does not have a written/
> signed document? At least the FSF requires you to given them a written
> and signed statement to that effect. And if it's not valid, why bother
> doing it at all?
>
> Also, the code is released under BSD license, so why is it important if
> it says "Copyright Foo, Inc" or something else? We will be able to use
> it regardless of the copyright assignment, as will anyone else.
>
> One point may be that if PGDG doesn't have a "Copyright" line in the
> header, it can't then automatically increment the year in there when the
> time comes. Does this have anything to do with it? It may also have to
> do with when someone from PGDG fixes a bug in that code.

[ Patch author added as CC.]

I think we just felt that an explicit copyright to someone else in our
code could be confusing. I don't believe there is any fundamental
reason to remove it, but it just seems best to do that.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Alvaro Herrera wrote:
>> Bruce Momjian wrote:
>>> Tom Lane wrote:
>>>> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
>>>>> sslinfo contrib module - information about current SSL certificate
>>>>> Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
>>>> It was premature to add this: Bruce is still trying to get a copyright
>>>> assignment out of the author.
>>> I got it this morning. The text they sent was:
>>>
>>>>> The copyright has to be removed so it can be copyrighted by the
>>>>> PostgreSQL Global Development Group. Is that OK? We can still keep
>>>>> your name and company at the top.
>>>> Yes, it can be removed. I just wasn't aware that copyright transfer is
>>>> neccessary. Most open-source projects don't have such a requirement, and
>>>> individual portions of code are copyrighted by their respecitve authors.
>> I still don't understand why is the copyright "assignment" needed at
>> all. Is it even valid, given that the PGDG does not have a written/
>> signed document? At least the FSF requires you to given them a written
>> and signed statement to that effect. And if it's not valid, why bother
>> doing it at all?
>>
>> Also, the code is released under BSD license, so why is it important if
>> it says "Copyright Foo, Inc" or something else? We will be able to use
>> it regardless of the copyright assignment, as will anyone else.
>>
>> One point may be that if PGDG doesn't have a "Copyright" line in the
>> header, it can't then automatically increment the year in there when the
>> time comes. Does this have anything to do with it? It may also have to
>> do with when someone from PGDG fixes a bug in that code.
>
> [ Patch author added as CC.]

hmm ? actually the author seems to be Victor Wagner (vitus(at)cryptocom(dot)ru
- now in CC) - I don't have anything to do with that module ...

Stefan

Peter Eisentraut wrote:
> Log Message:
> -----------
> sslinfo contrib module - information about current SSL certificate
> Author: Victor Wagner <vitus(at)cryptocom(dot)ru>

This seems to have broken the bustard buildfarm member, which uses VPATH
IIRC:

make[1]: Leaving directory `/home/andrew/bf/root/HEAD/pgsql.19349/contrib/vacuumlo'
make[1]: Entering directory `/home/andrew/bf/root/HEAD/pgsql.19349/contrib/sslinfo'
Makefile:9: ../contrib-global.mk: No such file or directory
make[1]: *** No rule to make target `../contrib-global.mk'. Stop.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> This seems to have broken the bustard buildfarm member, which uses VPATH
> IIRC:

Fixed --- I noticed it about the same time you did. I'm surprised Peter
didn't get a Makefile right the first time though ...

regards, tom lane

Bruce Momjian wrote:
> > Yes, it can be removed. I just wasn't aware that copyright transfer
> > is neccessary. Most open-source projects don't have such a
> > requirement, and individual portions of code are copyrighted by
> > their respecitve authors.

This isn't a "copyright transfer", but if you just write "(C) me"
without anything else then you haven't given any license for anyone
else to use it. If we put a uniform copyright statement everywhere,
then this gives reasonable assurance (as in: we got away with it so
far) to everyone about the nature of the license and such. Your name
is still on record, so you are still the copyright holder under law.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Tom Lane wrote:
> Fixed --- I noticed it about the same time you did. I'm surprised
> Peter didn't get a Makefile right the first time though ...

I'm surprised how crazy the contrib makefiles got while I wasn't
looking. :) I was glad to get something working at all. The
uniformity isn't that great at the moment and I'm unsure about the
purpose of all that pgxs stuff there, but I think we've had that
discussion and I'm not interested in reopening it.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

Peter Eisentraut wrote:
> Tom Lane wrote:
> > Fixed --- I noticed it about the same time you did. I'm surprised
> > Peter didn't get a Makefile right the first time though ...
>
> I'm surprised how crazy the contrib makefiles got while I wasn't
> looking. :) I was glad to get something working at all. The
> uniformity isn't that great at the moment and I'm unsure about the
> purpose of all that pgxs stuff there, but I think we've had that
> discussion and I'm not interested in reopening it.

Full reply to long subject line for Alvaro. Note that the subject is a
single line, not multiple lines. The subject as sent is:

Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Peter Eisentraut wrote:
> > Tom Lane wrote:
> > > Fixed --- I noticed it about the same time you did. I'm surprised
> > > Peter didn't get a Makefile right the first time though ...
> >
> > I'm surprised how crazy the contrib makefiles got while I wasn't
> > looking. :) I was glad to get something working at all. The
> > uniformity isn't that great at the moment and I'm unsure about the
> > purpose of all that pgxs stuff there, but I think we've had that
> > discussion and I'm not interested in reopening it.
>
> Full reply to long subject line for Alvaro. Note that the subject is a
> single line, not multiple lines. The subject as sent is:
>
> Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL

OK, as a reply from the lists I see:

Subject: Re: [HACKERS] [COMMITTERS] pgsql: sslinfo contrib module - information

which has removed "about current SSL". Interestingly, in the mbox file
I see later emails with the even shorter subject:

Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module -

I do see that short subject thread starting with my post. Would someone
else post with that subject and see what we get? How do I see the
subject as sendmail is sending it out?

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > sslinfo contrib module - information about current SSL certificate
> > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
>
> It was premature to add this: Bruce is still trying to get a copyright
> assignment out of the author.

Test of wrapping of subject. Ignore.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Tom Lane wrote:
> petere(at)postgresql(dot)org (Peter Eisentraut) writes:
> > sslinfo contrib module - information about current SSL certificate
> > Author: Victor Wagner <vitus(at)cryptocom(dot)ru>
>
> It was premature to add this: Bruce is still trying to get a copyright
> assignment out of the author.

Test of wrapping of subject, please ignore.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

OK, I just emailed the long subject line to my gmail account, and got
the full text:

Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL

Interestingly, I looked at a copy of the email I sent to start the
truncated subject thread and see in my saved mbox file:

From bruce Sun Sep 3 23:57:49 2006
Subject: Re: [HACKERS] [COMMITTERS] pgsql: sslinfo contrib module -
information about current SSL
In-Reply-To: <24228(dot)1157382805(at)sss(dot)pgh(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>

Note the newline in the subject. What confuses me is how that newline
got in there if replying to other email didn't have that problem. One
thing I did do is to copy text from another email into that email.

---------------------------------------------------------------------------

Bruce Momjian wrote:
> Bruce Momjian wrote:
> > Peter Eisentraut wrote:
> > > Tom Lane wrote:
> > > > Fixed --- I noticed it about the same time you did. I'm surprised
> > > > Peter didn't get a Makefile right the first time though ...
> > >
> > > I'm surprised how crazy the contrib makefiles got while I wasn't
> > > looking. :) I was glad to get something working at all. The
> > > uniformity isn't that great at the moment and I'm unsure about the
> > > purpose of all that pgxs stuff there, but I think we've had that
> > > discussion and I'm not interested in reopening it.
> >
> > Full reply to long subject line for Alvaro. Note that the subject is a
> > single line, not multiple lines. The subject as sent is:
> >
> > Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module - information about current SSL
>
> OK, as a reply from the lists I see:
>
> Subject: Re: [HACKERS] [COMMITTERS] pgsql: sslinfo contrib module - information
>
> which has removed "about current SSL". Interestingly, in the mbox file
> I see later emails with the even shorter subject:
>
> Subject: Re: [COMMITTERS] pgsql: sslinfo contrib module -
>
> I do see that short subject thread starting with my post. Would someone
> else post with that subject and see what we get? How do I see the
> subject as sendmail is sending it out?
>
> --
> Bruce Momjian bruce(at)momjian(dot)us
> EnterpriseDB http://www.enterprisedb.com
>
> + If your life is a hard drive, Christ can be your backup. +
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
> subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> message can get through to the mailing list cleanly

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Subject wrap test, please ignore.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

Another email wrap test through majordomo, please ignore.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +