Lists: | pgsql-hackers |
---|
From: | Joe Abbate <jma(at)freedomcircle(dot)com> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | OPERATOR FAMILY and pg_dump |
Date: | 2011-09-07 15:14:31 |
Message-ID: | 4E678A57.9080103@freedomcircle.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Hi,
If a basic operator family is created, e.g.,
create operator family of1 using btree;
shouldn't pg_dump include this in its output? If not, why?
Joe
From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Joe Abbate <jma(at)freedomcircle(dot)com> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: OPERATOR FAMILY and pg_dump |
Date: | 2011-09-07 16:10:04 |
Message-ID: | 23896.1315411804@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Joe Abbate <jma(at)freedomcircle(dot)com> writes:
> If a basic operator family is created, e.g.,
> create operator family of1 using btree;
> shouldn't pg_dump include this in its output? If not, why?
Quoting from the pg_dump source code:
* We want to dump the opfamily only if (1) it contains "loose" operators
* or functions, or (2) it contains an opclass with a different name or
* owner. Otherwise it's sufficient to let it be created during creation
* of the contained opclass, and not dumping it improves portability of
* the dump.
I guess if it contains no opclasses and no operators either, this code
won't dump it, but isn't it rather useless in such a case?
regards, tom lane
From: | Joe Abbate <jma(at)freedomcircle(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: OPERATOR FAMILY and pg_dump |
Date: | 2011-09-07 16:24:43 |
Message-ID: | 4E679ACB.70302@freedomcircle.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On 09/07/2011 12:10 PM, Tom Lane wrote:
> I guess if it contains no opclasses and no operators either, this code
> won't dump it, but isn't it rather useless in such a case?
Yes, I think it's useless, like a book cover without the contents, but
ISTM it should still be dumped (perhaps someone started defining a
family and forgot about it--oh, the puns that come to mind).
Joe