Re: patch for contrib/isn

Lists: pgsql-hackers
From: Jan Otto <asche(at)me(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: patch for contrib/isn
Date: 2010-08-04 17:32:58
Message-ID: 3513F71B-D558-436A-B89D-3C6B94D65264@me.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

hi all,

currently i am working on a big project for a german bookseller and
publisher. one of the requirements was correct hyphenation of ISBN-13
for about 14.400.000 books in postgresql database. so added support
for hyphenating isbn with the new 979-prefix and additionally added all
missing ranges since year 2006 for isbn with 978-prefix.

patch against HEAD is attached and validated against a lot of previously
wrong and correct hyphenated isbn.

regards, jan

Attachment Content-Type Size
contrib_isn-1.patch application/octet-stream 25.4 KB
From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Jan Otto <asche(at)me(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for contrib/isn
Date: 2010-08-04 17:56:16
Message-ID: 1280944576.2025.51.camel@jd-desktop.unknown.charter.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote:
> hi all,
>
> currently i am working on a big project for a german bookseller and
> publisher. one of the requirements was correct hyphenation of ISBN-13
> for about 14.400.000 books in postgresql database. so added support
> for hyphenating isbn with the new 979-prefix and additionally added all
> missing ranges since year 2006 for isbn with 978-prefix.
>
> patch against HEAD is attached and validated against a lot of previously
> wrong and correct hyphenated isbn.
>
> regards, jan
>

Great! Thanks. We will get it on the review list.

Joshua D. Drake

--
PostgreSQL.org Major Contributor
Command Prompt, Inc: http://www.commandprompt.com/ - 509.416.6579
Consulting, Training, Support, Custom Development, Engineering
http://twitter.com/cmdpromptinc | http://identi.ca/commandprompt

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: <jd(at)commandprompt(dot)com>,"Jan Otto" <asche(at)me(dot)com>
Cc: <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch for contrib/isn
Date: 2010-08-04 18:58:32
Message-ID: 4C59720802000025000341D9@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

"Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:
> On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote:

>> patch against HEAD is attached and validated against a lot of
>> previously wrong and correct hyphenated isbn.

> Great! Thanks. We will get it on the review list.

I added it as "isbn update" to the 2010-09 CommitFest page.

-Kevin

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov>
Cc: jd(at)commandprompt(dot)com, Jan Otto <asche(at)me(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for contrib/isn
Date: 2010-08-04 19:36:38
Message-ID: AANLkTikD357wRPFA5w-Nk5veCttGmmvsVGyCEBA25cWu@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Aug 4, 2010 at 2:58 PM, Kevin Grittner
<Kevin(dot)Grittner(at)wicourts(dot)gov> wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> wrote:
>> On Wed, 2010-08-04 at 19:32 +0200, Jan Otto wrote:
>
>>> patch against HEAD is attached and validated against a lot of
>>> previously wrong and correct hyphenated isbn.
>
>> Great! Thanks. We will get it on the review list.
>
> I added it as "isbn update" to the 2010-09 CommitFest page.

Please put "contrib/isn" in the name somewhere so that there is some
overlap between the subject line and the CF entry. I can't tell you
how many times I've gone "oh, crud, what was the subject line for the
latest version of the \ef / \sf patch?" in the last two weeks.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company

From: "Kevin Grittner" <Kevin(dot)Grittner(at)wicourts(dot)gov>
To: "Robert Haas" <robertmhaas(at)gmail(dot)com>
Cc: <jd(at)commandprompt(dot)com>,"Jan Otto" <asche(at)me(dot)com>, <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch for contrib/isn
Date: 2010-08-04 19:50:19
Message-ID: 4C597E2B02000025000341EB@gw.wicourts.gov
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Please put "contrib/isn" in the name somewhere so that there is
> some overlap between the subject line and the CF entry.

It is now "contrib/isn isbn update".

-Kevin

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Jan Otto <asche(at)me(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for contrib/isn
Date: 2010-08-06 21:08:47
Message-ID: 1281128927.2563.10.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On ons, 2010-08-04 at 19:32 +0200, Jan Otto wrote:
> patch against HEAD is attached and validated against a lot of
> previously wrong and correct hyphenated isbn.

I think this module could use a regression test.

From: Jan Otto <asche(at)me(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: patch for contrib/isn
Date: 2010-08-10 15:23:02
Message-ID: 23574EFC-E2BE-4A08-8CD6-605912233A3E@me.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On Aug 6, 2010, at 11:08 PM, Peter Eisentraut wrote:

> On ons, 2010-08-04 at 19:32 +0200, Jan Otto wrote:
>> patch against HEAD is attached and validated against a lot of
>> previously wrong and correct hyphenated isbn.
>
> I think this module could use a regression test.

i'll take a look at this within next days.

regards, jan