Re: head contrib is broken (crypto)

Lists: pgsql-hackers
From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: head contrib is broken (crypto)
Date: 2009-08-04 20:59:17
Message-ID: 1249419557.1392.2.camel@localhost
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

It seems that last contrib crypto changes broke buildfarm. You can see
problem e.g. here:

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=emperor_moth&dt=2009-08-04%2020:06:01

I don't have time to look on it now. But it should be reproducible
everywhere.

Zdenek

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: head contrib is broken (crypto)
Date: 2009-08-04 21:55:32
Message-ID: 20090804215532.GS6494@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Zdenek Kotala wrote:
> It seems that last contrib crypto changes broke buildfarm. You can see
> problem e.g. here:
>
> http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=emperor_moth&dt=2009-08-04%2020:06:01
>
> I don't have time to look on it now. But it should be reproducible
> everywhere.

It's not crypto changes that's the problem -- it's bytea now
being output in hex form (encrypt and decrypt both return bytea):

*** /store/postgres/buildfarm/emperor_moth/HEAD/pgsql.10027/contrib/pgcrypto/expected/3des.out Tue Aug 4 22:06:20 2009
--- /store/postgres/buildfarm/emperor_moth/HEAD/pgsql.10027/contrib/pgcrypto/results/3des.out Tue Aug 4 22:13:42 2009
***************
*** 37,44 ****
-- decrypt
select decrypt(encrypt('foo', '0123456', '3des'), '0123456', '3des');
decrypt
! ---------
! foo
(1 row)

-- iv
--- 37,44 ----
-- decrypt
select decrypt(encrypt('foo', '0123456', '3des'), '0123456', '3des');
decrypt
! ----------
! \x666f6f
(1 row)

-- iv

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: head contrib is broken (crypto)
Date: 2009-08-04 22:29:24
Message-ID: 23095.1249424964@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> It's not crypto changes that's the problem -- it's bytea now
> being output in hex form (encrypt and decrypt both return bytea):

I was insufficiently careful about checking the non-core regression
tests :-(. Mea culpa.

regards, tom lane