Re: [patch] Client-only installation on Windows

Hello,

According to this page,

http://www.postgresql.org/docs/current/static/install-procedure.html

client-only installation is possible on UNIX/Linux like this:

gmake -C src/bin install
gmake -C src/include install
gmake -C src/interfaces install
gmake -C doc install

With the attached patch, you can do client-only installation on Windows like
this:

install.bat <install_dir> client

This installs:

* client applications (both core and contrib)
* DLLs for libpq and ECPG
* header files
* import libraries
* pg_service.conf.sample and psqlrc.sample
* symbol files (*.pdb) for the above modules

If the second argument is given as "client" or omitted, all files are
installed. With 9.4, the whole installation takes up about 80 MB, and the
client-only installation takes up only 24 MB.

Any comments would be appreciated.

Regards
MauMau

On 12/06/2013 09:16 AM, MauMau wrote:
> Hello,
>
> According to this page,
>
> http://www.postgresql.org/docs/current/static/install-procedure.html
>
> client-only installation is possible on UNIX/Linux like this:
>
> gmake -C src/bin install
> gmake -C src/include install
> gmake -C src/interfaces install
> gmake -C doc install
>
> With the attached patch, you can do client-only installation on
> Windows like this:
>
> install.bat <install_dir> client
>
> This installs:
>
> * client applications (both core and contrib)
> * DLLs for libpq and ECPG
> * header files
> * import libraries
> * pg_service.conf.sample and psqlrc.sample
> * symbol files (*.pdb) for the above modules
>
> If the second argument is given as "client" or omitted, all files are
> installed. With 9.4, the whole installation takes up about 80 MB, and
> the client-only installation takes up only 24 MB.
>
> Any comments would be appreciated

This looks OK, and I'll commit it after I have a chance to give it a
quick test (probably at the same time as I test the VS2013 patch)..

Is there any reason why pgbench is listed in @client_program_files as
well as @client_contribs? AFAICT it should only be in the latter.

cheers

andrew

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
> Is there any reason why pgbench is listed in @client_program_files as
> well as @client_contribs? AFAICT it should only be in the latter.

Thank you for reviewing the patch. Yes, you are right. I removed pgbench
from @client_program_files. In addition, I added some documentation, as
well as modifying the usage at the end of install.pl.

I'll update the CommitFest entry shortly.

Regards
MauMau

On 01/24/2014 05:36 AM, MauMau wrote:
> From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
>> Is there any reason why pgbench is listed in @client_program_files as
>> well as @client_contribs? AFAICT it should only be in the latter.
>
> Thank you for reviewing the patch. Yes, you are right. I removed
> pgbench from @client_program_files. In addition, I added some
> documentation, as well as modifying the usage at the end of install.pl.
>
> I'll update the CommitFest entry shortly.
>
>

Committed, with a little help from perltidy.

cheers

andrew

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Committed, with a little help from perltidy.

I think you forgot to push to master? The only recent commit I see from
you is the Visual Studio 2013 fixes.

regards, tom lane

On 01/26/2014 03:14 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Committed, with a little help from perltidy.
> I think you forgot to push to master? The only recent commit I see from
> you is the Visual Studio 2013 fixes.
>
>

Oh, hell and damnation. That's going to make my life VERY difficult.
Thanks for letting me know.

cheers

andrew

Andrew Dunstan <andrew(at)dunslane(dot)net> schrieb:
>
>On 01/26/2014 03:14 PM, Tom Lane wrote:
>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>> Committed, with a little help from perltidy.
>> I think you forgot to push to master? The only recent commit I see
>from
>> you is the Visual Studio 2013 fixes.
>>
>>
>
>
>Oh, hell and damnation. That's going to make my life VERY difficult.
>Thanks for letting me know.

Why would it make things difficult? git fetch; git rebase origin/master; git push. That should be it.

---
Please excuse brevity and formatting - I am writing this on my mobile phone.

On 01/26/2014 05:04 PM, Andres Freund wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> schrieb:
>> On 01/26/2014 03:14 PM, Tom Lane wrote:
>>> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>>>> Committed, with a little help from perltidy.
>>> I think you forgot to push to master? The only recent commit I see
>> from
>>> you is the Visual Studio 2013 fixes.
>>>
>>>
>>
>> Oh, hell and damnation. That's going to make my life VERY difficult.
>> Thanks for letting me know.
> Why would it make things difficult? git fetch; git rebase origin/master; git push. That should be it.

Maybe if I had more facility with git I'd know more what to do. But I'd
merged it into another branch and then after I wound this back, rolled
forward and recommitted (and this time pushed) the patch I'm not sure
not how to fix that branch. I'll manage it somehow I guess.

cheers

andrew