| Lists: | pgsql-committerspgsql-hackers |
|---|
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 14:56:36 |
| Message-ID: | E1SDzjI-000603-UG@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
Per buildfarm, this is now needed by contrib/pg_stat_statements.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/5e83854d71bb05403768a97a415a129b0081564b
Modified Files
--------------
src/include/parser/keywords.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 15:41:01 |
| Message-ID: | 4F77258D.9040806@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On 03/31/2012 10:56 AM, Tom Lane wrote:
> Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
>
> Per buildfarm, this is now needed by contrib/pg_stat_statements.
>
It seems to have broken mingw earlier now :-(
cheers
andrew
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 15:59:47 |
| Message-ID: | 20422.1333209587@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/31/2012 10:56 AM, Tom Lane wrote:
>> Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
>>
>> Per buildfarm, this is now needed by contrib/pg_stat_statements.
> It seems to have broken mingw earlier now :-(
Ugh. It looks like ecpg (and also pg_dump) are defining symbols named
ScanKeywords and NumScanKeywords, but relying on the backend's
keywords.h to provide global declarations for those. And this doesn't
work once we PGDLLIMPORT-decorate those declarations.
The only simple fix I can see is to rename the symbols in ecpg and
pg_dump to something else. This is probably a good thing anyway to
reduce confusion. Anybody have another idea?
regards, tom lane
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 16:52:37 |
| Message-ID: | 4F773655.30004@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
On 03/31/2012 11:59 AM, Tom Lane wrote:
> Andrew Dunstan<andrew(at)dunslane(dot)net> writes:
>> On 03/31/2012 10:56 AM, Tom Lane wrote:
>>> Add PGDLLIMPORT to ScanKeywords and NumScanKeywords.
>>>
>>> Per buildfarm, this is now needed by contrib/pg_stat_statements.
>> It seems to have broken mingw earlier now :-(
> Ugh. It looks like ecpg (and also pg_dump) are defining symbols named
> ScanKeywords and NumScanKeywords, but relying on the backend's
> keywords.h to provide global declarations for those. And this doesn't
> work once we PGDLLIMPORT-decorate those declarations.
>
> The only simple fix I can see is to rename the symbols in ecpg and
> pg_dump to something else. This is probably a good thing anyway to
> reduce confusion. Anybody have another idea?
>
>
Seems the sane thing to do.
cheers
andrew
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Add PGDLLIMPORT to ScanKeywords and NumScanKeywords. |
| Date: | 2012-03-31 17:17:12 |
| Message-ID: | 22075.1333214232@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-committers pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> On 03/31/2012 11:59 AM, Tom Lane wrote:
>> The only simple fix I can see is to rename the symbols in ecpg and
>> pg_dump to something else. This is probably a good thing anyway to
>> reduce confusion. Anybody have another idea?
> Seems the sane thing to do.
Done, we'll see how the buildfarm likes this version ...
regards, tom lane