Re: Patch to remove inconsistency in dependency.c

Lists: pgsql-hackers
From: Muhammad Aqeel <muhammad(dot)aqeel(at)enterprisedb(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Patch to remove inconsistency in dependency.c
Date: 2009-08-07 09:25:51
Message-ID: e1e5ec200908070225q74d60827qf9d3061f3312833e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi

Description:
=========

Inconsistency in dependency.c file's object_classes array elements and
dependency.h file's enum ObjectClass elements. Following elements in
object_classes array were missing.

ForeignDataWrapperRelationId for OCLASS_FDW
ForeignServerRelationId for OCLASS_FOREIGN_SERVER
UserMappingRelationId for OCLASS_USER_MAPPING

Files Changed:
=========

1. src/backend/catalog/dependency.c

thanks

--Aqeel

Attachment Content-Type Size
dependency.patch text/x-patch 873 bytes

From: Muhammad Aqeel <muhammad(dot)aqeel(at)enterprisedb(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Ahsan Hadi <ahsan(dot)hadi(at)enterprisedb(dot)com>
Subject: Patch to remove inconsistency in dependency.c
Date: 2009-08-07 09:32:12
Message-ID: e1e5ec200908070232t7249f4d8s32be91e245fd765b@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi

Description:
=========

Inconsistency in dependency.c file's object_classes array elements and
dependency.h file's enum ObjectClass elements. Following elements in
object_classes array were missing.

ForeignDataWrapperRelationId for OCLASS_FDW
ForeignServerRelationId for OCLASS_FOREIGN_SERVER
UserMappingRelationId for OCLASS_USER_MAPPING

Files Changed:
=========

1. src/backend/catalog/dependency.c

thanks

--Aqeel

Attachment Content-Type Size
dependency.patch text/x-patch 873 bytes

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Muhammad Aqeel <muhammad(dot)aqeel(at)enterprisedb(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Ahsan Hadi <ahsan(dot)hadi(at)enterprisedb(dot)com>
Subject: Re: Patch to remove inconsistency in dependency.c
Date: 2009-08-07 15:04:48
Message-ID: 20833.1249657488@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Muhammad Aqeel <muhammad(dot)aqeel(at)enterprisedb(dot)com> writes:
> Inconsistency in dependency.c file's object_classes array elements and
> dependency.h file's enum ObjectClass elements. Following elements in
> object_classes array were missing.

Good catch --- seems to have been some sloppiness in the SQL/MED patch.
Will fix, thanks.

regards, tom lane