| Lists: | pgsql-hackers |
|---|
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | new pgindent run before branch? |
| Date: | 2016-08-10 20:02:27 |
| Message-ID: | CA+Tgmobwy76rOF6J_XttTBrK7mm9QLcKfqmY8htgxss6BFz6pA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
Would anyone mind too much if I refreshed typedefs.list and
re-indented the whole tree before we branch? There's not too much
churn at the moment, and I feel like it would be nice to start the
cycle in as clean a state as possible.
Current results of this attached.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| pgindent.patch | application/x-download | 27.3 KB |
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-10 20:44:12 |
| Message-ID: | 20160810204412.GA20156@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 04:02:27PM -0400, Robert Haas wrote:
> Hi,
>
> Would anyone mind too much if I refreshed typedefs.list and
> re-indented the whole tree before we branch? There's not too much
> churn at the moment, and I feel like it would be nice to start the
> cycle in as clean a state as possible.
>
> Current results of this attached.
Sure, seems like a good idea.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-10 21:04:36 |
| Message-ID: | 28193.1470863076@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Would anyone mind too much if I refreshed typedefs.list and
> re-indented the whole tree before we branch?
+1, I was planning to do that myself.
regards, tom lane
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:19:51 |
| Message-ID: | CA+TgmoaYFvMDwwubrn4vHx1m21PwAB2ETaJ7sXhAmc05x9BadA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> Would anyone mind too much if I refreshed typedefs.list and
>> re-indented the whole tree before we branch?
>
> +1, I was planning to do that myself.
Great. Are you handling creating the new branch? If so, it probably
makes sense for you to do this just beforehand.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:23:14 |
| Message-ID: | 6492.1470882194@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Would anyone mind too much if I refreshed typedefs.list and
>>> re-indented the whole tree before we branch?
>> +1, I was planning to do that myself.
> Great. Are you handling creating the new branch?
Yeah, I guess. I've made most of them lately.
> If so, it probably
> makes sense for you to do this just beforehand.
OK.
regards, tom lane
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:24:29 |
| Message-ID: | 20160811022429.GB20156@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 10:23:14PM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Wed, Aug 10, 2016 at 5:04 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >>> Would anyone mind too much if I refreshed typedefs.list and
> >>> re-indented the whole tree before we branch?
>
> >> +1, I was planning to do that myself.
>
> > Great. Are you handling creating the new branch?
>
> Yeah, I guess. I've made most of them lately.
>
> > If so, it probably
> > makes sense for you to do this just beforehand.
>
> OK.
I am confused --- are you pgindenting just HEAD and not 9.6? Why?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:31:35 |
| Message-ID: | 6762.1470882695@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> I am confused --- are you pgindenting just HEAD and not 9.6? Why?
The point is to pgindent while they're still the same.
regards, tom lane
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:34:54 |
| Message-ID: | 20160811023454.GC20156@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 10:31:35PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > I am confused --- are you pgindenting just HEAD and not 9.6? Why?
>
> The point is to pgindent while they're still the same.
So I read this:
> >> +1, I was planning to do that myself.
>
> > Great. Are you handling creating the new branch?
>
> Yeah, I guess. I've made most of them lately.
>
> > If so, it probably
> > makes sense for you to do this just beforehand.
>
> OK.
It sounds like you are saying that the branch is to happen before the
pgindent run. Am I missing something?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:35:44 |
| Message-ID: | 6916.1470882944@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> It sounds like you are saying that the branch is to happen before the
> pgindent run. Am I missing something?
I read it as pgindent then branch.
regards, tom lane
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:39:16 |
| Message-ID: | 20160811023916.GD20156@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 10:35:44PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > It sounds like you are saying that the branch is to happen before the
> > pgindent run. Am I missing something?
>
> I read it as pgindent then branch.
OK, good.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new pgindent run before branch? |
| Date: | 2016-08-11 02:48:13 |
| Message-ID: | CA+TgmoYMCjG303-N1CwLDd8mSUSXrFt=1kXS7jhrZFJXUeBFcQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Aug 10, 2016 at 10:23 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Great. Are you handling creating the new branch?
>
> Yeah, I guess. I've made most of them lately.
I'll do it if you want.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company