| Lists: | pgsql-hackers |
|---|
| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pg_regress writes into source tree |
| Date: | 2014-12-12 03:02:26 |
| Message-ID: | 548A5AC2.5040003@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
When using a vpath build pg_regress writes the processed input/*.source
files into the *source* tree, which isn't supposed to happen.
This appears to be a thinko introduced in this patch:
e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b
The attached patch fixes it.
| Attachment | Content-Type | Size |
|---|---|---|
| regress-outputdir.patch | application/x-patch | 511 bytes |
| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2014-12-12 13:45:08 |
| Message-ID: | 20141212134508.GT1768@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> When using a vpath build pg_regress writes the processed input/*.source
> files into the *source* tree, which isn't supposed to happen.
>
> This appears to be a thinko introduced in this patch:
> e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b
Oh, I noticed this while doing the dummy_seclabel move to
src/test/modules and I thought it was on purpose; if I'm not
mistaken this is why we had to add the .sql file to .gitignore.
Another thing in that patch was that I had to add the sql/ directory to
the source tree, but other than that .gitignore file it was empty.
Maybe pg_regress should create the sql/ directory in the build dir if it
doesn't exist. This is only a problem if a pg_regress suite only runs
stuff from input/, because otherwise the sql/ dir already exists in the
source.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2014-12-18 07:46:57 |
| Message-ID: | 20141218074657.GX5023@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
On 2014-12-11 22:02:26 -0500, Peter Eisentraut wrote:
> When using a vpath build pg_regress writes the processed input/*.source
> files into the *source* tree, which isn't supposed to happen.
>
> This appears to be a thinko introduced in this patch:
> e3fc4a97bc8ee82a78605b5ffe79bd4cf3c6213b
>
> The attached patch fixes it.
I've been annoyed by this more than once, specifically when trying to
run tests with different compilation settings at once...
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2014-12-18 08:02:26 |
| Message-ID: | CAB7nPqS2kAAQWnF6tmk1aV2o7knJ9r7V5Mro-PcPWceiYpT16Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Another thing in that patch was that I had to add the sql/ directory to
> the source tree, but other than that .gitignore file it was empty.
> Maybe pg_regress should create the sql/ directory in the build dir if it
> doesn't exist. This is only a problem if a pg_regress suite only runs
> stuff from input/, because otherwise the sql/ dir already exists in the
> source.
+1 for having pg_regress create the sql/ directory when it does not
exist. Current behavior is annoying when modules having only tests in
input/...
--
Michael
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2014-12-18 23:05:01 |
| Message-ID: | 54935D9D.7010608@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/18/2014 03:02 AM, Michael Paquier wrote:
> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> Another thing in that patch was that I had to add the sql/ directory to
>> the source tree, but other than that .gitignore file it was empty.
>> Maybe pg_regress should create the sql/ directory in the build dir if it
>> doesn't exist. This is only a problem if a pg_regress suite only runs
>> stuff from input/, because otherwise the sql/ dir already exists in the
>> source.
> +1 for having pg_regress create the sql/ directory when it does not
> exist. Current behavior is annoying when modules having only tests in
> input/...
That seems like a separate issue. I think Peter should commit his patch
and backpatch it immediately, and we can deal with the missing sql
directory when someone sends in a patch.
cheers
andrew
| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2015-02-13 21:24:48 |
| Message-ID: | 54DE6BA0.30408@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>
> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>
>>> Another thing in that patch was that I had to add the sql/ directory to
>>> the source tree, but other than that .gitignore file it was empty.
>>> Maybe pg_regress should create the sql/ directory in the build dir
>>> if it
>>> doesn't exist. This is only a problem if a pg_regress suite only runs
>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>> source.
>> +1 for having pg_regress create the sql/ directory when it does not
>> exist. Current behavior is annoying when modules having only tests in
>> input/...
>
>
>
> That seems like a separate issue. I think Peter should commit his
> patch and backpatch it immediately, and we can deal with the missing
> sql directory when someone sends in a patch.
What's happened on this?
cheers
andrew
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2015-02-14 05:20:02 |
| Message-ID: | CAB7nPqQ_HmwgxL+tC7ftjDxQt-dK2KyhtCzfj9uvi_8-z101JQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
> On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>>
>>
>> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>>>
>>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>>
>>>> Another thing in that patch was that I had to add the sql/ directory to
>>>> the source tree, but other than that .gitignore file it was empty.
>>>> Maybe pg_regress should create the sql/ directory in the build dir if it
>>>> doesn't exist. This is only a problem if a pg_regress suite only runs
>>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>>> source.
>>>
>>> +1 for having pg_regress create the sql/ directory when it does not
>>> exist. Current behavior is annoying when modules having only tests in
>>> input/...
>>
>>
>>
>>
>> That seems like a separate issue. I think Peter should commit his patch
>> and backpatch it immediately, and we can deal with the missing sql directory
>> when someone sends in a patch.
>
>
>
> What's happened on this?
Nothing has been committed, and as far as I understood this patch
could have been simply pushed...
--
Michael
| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2015-04-08 01:28:39 |
| Message-ID: | 55248447.1060201@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 2/13/15 11:20 PM, Michael Paquier wrote:
> On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>
>> On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>>>
>>>
>>> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>>>>
>>>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>>>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>>>
>>>>> Another thing in that patch was that I had to add the sql/ directory to
>>>>> the source tree, but other than that .gitignore file it was empty.
>>>>> Maybe pg_regress should create the sql/ directory in the build dir if it
>>>>> doesn't exist. This is only a problem if a pg_regress suite only runs
>>>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>>>> source.
>>>>
>>>> +1 for having pg_regress create the sql/ directory when it does not
>>>> exist. Current behavior is annoying when modules having only tests in
>>>> input/...
>>>
>>>
>>>
>>>
>>> That seems like a separate issue. I think Peter should commit his patch
>>> and backpatch it immediately, and we can deal with the missing sql directory
>>> when someone sends in a patch.
>>
>>
>>
>> What's happened on this?
>
> Nothing has been committed, and as far as I understood this patch
> could have been simply pushed...
Just so this doesn't get lost... did something make it into a CommitFest
on this?
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com
| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_regress writes into source tree |
| Date: | 2015-04-08 02:02:32 |
| Message-ID: | CAB7nPqSkezQwDSOhLo-b+6EOP=yMJxs0ZPaTAu+a5K2cynmyrA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Apr 8, 2015 at 10:28 AM, Jim Nasby wrote:
> Just so this doesn't get lost... did something make it into a CommitFest on
> this?
Peter's patch has been committed as 64cdbbc, while the idea to create
sql/ by pg_regress if it is not present did not gather much interest
in this CF:
https://commitfest.postgresql.org/4/100/
--
Michael