Re: settings without unit

Lists: pgsql-hackers
From: Euler Taveira <euler(at)timbira(dot)com(dot)br>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: settings without unit
Date: 2014-09-04 23:50:36
Message-ID: 5408FACC.3000003@timbira.com.br
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi,

I noticed that a setting in pg_settings without units have NULL and ""
as unit values ("" for integer and NULL for the other ones). Could we be
consistent? It is like that since units were introduced (b517e65). No
unit means unit = NULL. A proposed patch is attached.

--
Euler Taveira Timbira - http://www.timbira.com.br/
PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Attachment Content-Type Size
guc.diff text/x-patch 349 bytes

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Euler Taveira <euler(at)timbira(dot)com(dot)br>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: settings without unit
Date: 2014-10-13 20:11:53
Message-ID: 20141013201153.GI21267@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Sep 4, 2014 at 08:50:36PM -0300, Euler Taveira wrote:
> Hi,
>
> I noticed that a setting in pg_settings without units have NULL and ""
> as unit values ("" for integer and NULL for the other ones). Could we be
> consistent? It is like that since units were introduced (b517e65). No
> unit means unit = NULL. A proposed patch is attached.

Thanks. Patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +