Re: Documentation fix for pg_recvlogical's --create mode

Lists: pgsql-hackers
From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Documentation fix for pg_recvlogical's --create mode
Date: 2014-09-22 06:46:14
Message-ID: CAB7nPqQFSU7RxxuB8CDmJSYF7wf3Lr4TNAtvtcYhcdU-R4HcEg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi all,

In the documentation of pg_recvlogical here
(http://www.postgresql.org/docs/devel/static/app-pgrecvlogical.html),
there is the following sentence:
"Create a new logical replication slot with the name specified in
--slot, using the output plugin --plugin, then exit."
Actually that's not completely true, we can create a replication slot
and then start streaming by combining --start and --create. Process
will only exit if --start is not used. Patch is attached.
Regards,
--
Michael

Attachment Content-Type Size
20140922_pg_recvlogical_docfix.patch text/x-patch 699 bytes
From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Documentation fix for pg_recvlogical's --create mode
Date: 2014-09-29 23:52:40
Message-ID: 20140929235240.GM2084@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2014-09-22 15:46:14 +0900, Michael Paquier wrote:
> In the documentation of pg_recvlogical here
> (http://www.postgresql.org/docs/devel/static/app-pgrecvlogical.html),
> there is the following sentence:
> "Create a new logical replication slot with the name specified in
> --slot, using the output plugin --plugin, then exit."
> Actually that's not completely true, we can create a replication slot
> and then start streaming by combining --start and --create. Process
> will only exit if --start is not used. Patch is attached.

Committed. Thanks. And thannks Robert for the reminder, I'd indeed have
missed this...

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services