Re: old warning in docs

Lists: pgsql-hackers
From: Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: old warning in docs
Date: 2013-10-07 11:51:44
Message-ID: 5252A050.2080103@pgexperts.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


Given that we have not supported releases older than 8.3 for quite a
while, do we need to keep this in extend.sgml any longer?

<caution>
<para>
Changing <varname>PG_CONFIG</varname> only works when building
against <productname>PostgreSQL</productname> 8.3 or later.
With older releases it does not work to set it to anything except
<literal>pg_config</>; you must alter your <varname>PATH</>
to select the installation to build against.
</para>
</caution>

cheers

andrew


From: David Fetter <david(at)fetter(dot)org>
To: Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2013-10-07 15:43:27
Message-ID: 20131007154327.GA18646@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Oct 07, 2013 at 07:51:44AM -0400, Andrew Dunstan wrote:
>
> Given that we have not supported releases older than 8.3 for quite a
> while, do we need to keep this in extend.sgml any longer?
>
> <caution>
> <para>
> Changing <varname>PG_CONFIG</varname> only works when building
> against <productname>PostgreSQL</productname> 8.3 or later.
> With older releases it does not work to set it to anything except
> <literal>pg_config</>; you must alter your <varname>PATH</>
> to select the installation to build against.
> </para>
> </caution>

I say "bin it." That reminds me. There are probably a lot of places
in the docs that refer to versions of PostgreSQL a good bit older than
8.3. Will grep and patch as I get the time.

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate


From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2013-10-08 16:27:08
Message-ID: CA+TgmobXb4PW8F87iOfdAMyK2JU9VpeUgp2_QVME6yfZyK0E+A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Oct 7, 2013 at 7:51 AM, Andrew Dunstan
<andrew(dot)dunstan(at)pgexperts(dot)com> wrote:
> Given that we have not supported releases older than 8.3 for quite a while,
> do we need to keep this in extend.sgml any longer?

+1 for removing that (but only in master, not the back-branches).

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, andrew(dot)dunstan(at)pgexperts(dot)com
Subject: Re: old warning in docs
Date: 2013-10-08 18:51:08
Message-ID: CABUevEw_8cFLhJyQa9=g1whpoxdmSuUEVuqCkhOyWd_LFDrc1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Oct 8, 2013 6:27 PM, "Robert Haas" <robertmhaas(at)gmail(dot)com> wrote:
>
> On Mon, Oct 7, 2013 at 7:51 AM, Andrew Dunstan
> <andrew(dot)dunstan(at)pgexperts(dot)com> wrote:
> > Given that we have not supported releases older than 8.3 for quite a
while,
> > do we need to keep this in extend.sgml any longer?
>
> +1 for removing that (but only in master, not the back-branches).
>

+1, and definitely not in back branches.

/Magnus


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: David Fetter <david(at)fetter(dot)org>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2014-02-13 15:55:26
Message-ID: 20140213155526.GA32126@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Oct 7, 2013 at 08:43:27AM -0700, David Fetter wrote:
> On Mon, Oct 07, 2013 at 07:51:44AM -0400, Andrew Dunstan wrote:
> >
> > Given that we have not supported releases older than 8.3 for quite a
> > while, do we need to keep this in extend.sgml any longer?
> >
> > <caution>
> > <para>
> > Changing <varname>PG_CONFIG</varname> only works when building
> > against <productname>PostgreSQL</productname> 8.3 or later.
> > With older releases it does not work to set it to anything except
> > <literal>pg_config</>; you must alter your <varname>PATH</>
> > to select the installation to build against.
> > </para>
> > </caution>
>
> I say "bin it." That reminds me. There are probably a lot of places
> in the docs that refer to versions of PostgreSQL a good bit older than
> 8.3. Will grep and patch as I get the time.

I have created the attached patch which removes many of the pre-8.0
references, and trims some of the 8.1-8.3 references. There are
probably some of these that should be kept, but it is easier to show you
all the possibilities and we can trim down the removal list based on
feedback.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
version.diff text/x-diff 23.7 KB

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2014-02-16 00:19:46
Message-ID: CA+TgmoZjMKDSHVEkS0DQe4OCQaBuBGGaRwyLd9FfP4+D8hTQBw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> I have created the attached patch which removes many of the pre-8.0
> references, and trims some of the 8.1-8.3 references. There are
> probably some of these that should be kept, but it is easier to show you
> all the possibilities and we can trim down the removal list based on
> feedback.

The changes to lobj.sgml seem pointless. I would also vote for
keeping xindex.sgml as-is. The rest of the changes seem like
improvements.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2014-02-16 00:34:20
Message-ID: 20140216003420.GC3651@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Feb 15, 2014 at 07:19:46PM -0500, Robert Haas wrote:
> On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > I have created the attached patch which removes many of the pre-8.0
> > references, and trims some of the 8.1-8.3 references. There are
> > probably some of these that should be kept, but it is easier to show you
> > all the possibilities and we can trim down the removal list based on
> > feedback.
>
> The changes to lobj.sgml seem pointless. I would also vote for
> keeping xindex.sgml as-is. The rest of the changes seem like
> improvements.

OK, done. Updated patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

Attachment Content-Type Size
version.diff text/x-diff 20.9 KB

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Andrew Dunstan <andrew(dot)dunstan(at)pgexperts(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: old warning in docs
Date: 2014-02-24 17:56:50
Message-ID: 20140224175650.GE16943@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Feb 15, 2014 at 07:34:20PM -0500, Bruce Momjian wrote:
> On Sat, Feb 15, 2014 at 07:19:46PM -0500, Robert Haas wrote:
> > On Thu, Feb 13, 2014 at 10:55 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > > I have created the attached patch which removes many of the pre-8.0
> > > references, and trims some of the 8.1-8.3 references. There are
> > > probably some of these that should be kept, but it is easier to show you
> > > all the possibilities and we can trim down the removal list based on
> > > feedback.
> >
> > The changes to lobj.sgml seem pointless. I would also vote for
> > keeping xindex.sgml as-is. The rest of the changes seem like
> > improvements.
>
> OK, done. Updated patch attached.

Patch applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +