Lists: | pgsql-hackers |
---|
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Server side lo-funcs name |
Date: | 2013-06-10 00:16:05 |
Message-ID: | 20130610.091605.250603479334631505.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
Recently we got a complain about server side large object function
names described in the doc:
http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
In the doc:
http://www.postgresql.org/docs/9.3/static/lo-funcs.html
"There are server-side functions callable from SQL that correspond to
each of the client-side functions described above; indeed, for the
most part the client-side functions are simply interfaces to the
equivalent server-side functions"
From the description it is hard for users to find out server side
functions "loread" and "lowrite" becuase they are looking for
"lo_read" and "lo_write". So I think his complain is fair. Included
patches attempt to fix the problem.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
Attachment | Content-Type | Size |
---|---|---|
lobj.sgml.patch | text/x-patch | 1.2 KB |
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Server side lo-funcs name |
Date: | 2013-06-10 21:58:50 |
Message-ID: | CA+TgmoaN8P2V0xtmGwAC90zpjx4O6ZMge+ErfCxqRz3MmtRGew@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Sun, Jun 9, 2013 at 8:16 PM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
> Recently we got a complain about server side large object function
> names described in the doc:
> http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
>
> In the doc:
> http://www.postgresql.org/docs/9.3/static/lo-funcs.html
>
> "There are server-side functions callable from SQL that correspond to
> each of the client-side functions described above; indeed, for the
> most part the client-side functions are simply interfaces to the
> equivalent server-side functions"
>
> From the description it is hard for users to find out server side
> functions "loread" and "lowrite" becuase they are looking for
> "lo_read" and "lo_write". So I think his complain is fair. Included
> patches attempt to fix the problem.
+ each of the client-side functions described above(please note
This line contains an obvious whitespace error, but more than that, I
think the resulting paragraph doesn't read very well this way. I
would suggest adding a new paragraph further down, maybe like this:
--- a/doc/src/sgml/lobj.sgml
+++ b/doc/src/sgml/lobj.sgml
@@ -572,6 +572,14 @@ SELECT lo_export(image.raster, '/tmp/motd') FROM image
The client-side functions do not require superuser privilege.
</para>
+ <para>
+ The functionality of <function>lo_read</function> and
+ <function>lo_write</function> is also available via server-side calls,
+ but the names of the server-side functions differ from the client side
+ interfaces in that they do not contain underscores. You must call
+ these functions as <function>loread</> and <function>lowrite</>.
+ </para>
+
</sect1>
<sect1 id="lo-examplesect">
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Server side lo-funcs name |
Date: | 2013-06-11 05:32:45 |
Message-ID: | 20130611.143245.624720650805074518.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
> Recently we got a complain about server side large object function
> names described in the doc:
> http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
>
> In the doc:
> http://www.postgresql.org/docs/9.3/static/lo-funcs.html
>
> "There are server-side functions callable from SQL that correspond to
> each of the client-side functions described above; indeed, for the
> most part the client-side functions are simply interfaces to the
> equivalent server-side functions"
>
>>From the description it is hard for users to find out server side
> functions "loread" and "lowrite" becuase they are looking for
> "lo_read" and "lo_write". So I think his complain is fair. Included
> patches attempt to fix the problem.
I have committed this.
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Server side lo-funcs name |
Date: | 2013-06-11 12:07:46 |
Message-ID: | CA+TgmoYnL4RV1qR28NHuNLR6wmC_YMsU+PZ5YmQUjvON-MgHsg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Tue, Jun 11, 2013 at 1:32 AM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>> Recently we got a complain about server side large object function
>> names described in the doc:
>> http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
>>
>> In the doc:
>> http://www.postgresql.org/docs/9.3/static/lo-funcs.html
>>
>> "There are server-side functions callable from SQL that correspond to
>> each of the client-side functions described above; indeed, for the
>> most part the client-side functions are simply interfaces to the
>> equivalent server-side functions"
>>
>>>From the description it is hard for users to find out server side
>> functions "loread" and "lowrite" becuase they are looking for
>> "lo_read" and "lo_write". So I think his complain is fair. Included
>> patches attempt to fix the problem.
>
> I have committed this.
Did you see my email with proposed alternative text? You didn't even
fix the whitespace error I pointed out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
---|---|
To: | robertmhaas(at)gmail(dot)com |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Server side lo-funcs name |
Date: | 2013-06-11 14:11:49 |
Message-ID: | 20130611.231149.1665169999265317098.t-ishii@sraoss.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
> On Tue, Jun 11, 2013 at 1:32 AM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>>> Recently we got a complain about server side large object function
>>> names described in the doc:
>>> http://www.postgresql.org/message-id/51B2413F.8010305@gmail.com
>>>
>>> In the doc:
>>> http://www.postgresql.org/docs/9.3/static/lo-funcs.html
>>>
>>> "There are server-side functions callable from SQL that correspond to
>>> each of the client-side functions described above; indeed, for the
>>> most part the client-side functions are simply interfaces to the
>>> equivalent server-side functions"
>>>
>>>>From the description it is hard for users to find out server side
>>> functions "loread" and "lowrite" becuase they are looking for
>>> "lo_read" and "lo_write". So I think his complain is fair. Included
>>> patches attempt to fix the problem.
>>
>> I have committed this.
>
> Did you see my email with proposed alternative text? You didn't even
> fix the whitespace error I pointed out.
I don't know why but I haven't received your email. I just found the
email in the web archive and it looks better than what I proposed. Do
you want to commit it yourself?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp
From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Server side lo-funcs name |
Date: | 2013-06-12 16:31:31 |
Message-ID: | CA+TgmoZWPnqow9YAiwcpHS+t0J7gGQkWRQmDOvvOfJmGK-jMRg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Lists: | pgsql-hackers |
On Tue, Jun 11, 2013 at 10:11 AM, Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:
>> Did you see my email with proposed alternative text? You didn't even
>> fix the whitespace error I pointed out.
>
> I don't know why but I haven't received your email. I just found the
> email in the web archive and it looks better than what I proposed. Do
> you want to commit it yourself?
Done. Thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company