| Lists: | pgsql-hackers |
|---|
| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | s/size_t/off_t/ in sendTimeLineHistory |
| Date: | 2013-01-14 22:27:07 |
| Message-ID: | 20130114222707.GC22155@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hi,
When looking at the report of probable fallout from the elog stuff I
noticed this warning:
walsender.c(366): warning #186: pointless comparison of unsigned integer with zero
Which is accurate, the rather unlikely problem of a seek error could not
be noticed atm and would probably send strange stuff over the wire.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| sendTimeLineHistory-off_t.patch | text/x-patch | 506 bytes |
| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: s/size_t/off_t/ in sendTimeLineHistory |
| Date: | 2013-01-14 22:49:05 |
| Message-ID: | 50F48B61.9010402@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 15.01.2013 00:27, Andres Freund wrote:
> When looking at the report of probable fallout from the elog stuff I
> noticed this warning:
>
> walsender.c(366): warning #186: pointless comparison of unsigned integer with zero
>
> Which is accurate, the rather unlikely problem of a seek error could not
> be noticed atm and would probably send strange stuff over the wire.
Thanks, applied.
- Heikki