| Lists: | pgsql-hackers |
|---|
| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Update comments for PGPROC/PGXACT split |
| Date: | 2012-05-13 20:52:31 |
| Message-ID: | 20120513205231.GB23040@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Many comment references to PGPROC and MyProc should now refer to PGXACT and
MyPgXact. This patch attempts to cover all such cases. In some places, a
comment refers collectively to all the xid-related fields, which span both
structures. I variously changed those to refer to either or both structures
depending on how I judged the emphasis.
The PGXACT patch extracted the PGPROC struct formerly embedded in each
GlobalTransaction. I updated a few comments accordingly.
The procarray.c leading comment described the procarray as "unsorted", but it
is sorted by memory address; I removed that word.
I include two typo-only fixes on related but already-accurate lines.
Thanks,
nm
| Attachment | Content-Type | Size |
|---|---|---|
| pgxact-comments-v1.patch | text/plain | 35.3 KB |
| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Update comments for PGPROC/PGXACT split |
| Date: | 2012-05-14 07:30:37 |
| Message-ID: | 4FB0B49D.3070503@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On 13.05.2012 23:52, Noah Misch wrote:
> Many comment references to PGPROC and MyProc should now refer to PGXACT and
> MyPgXact. This patch attempts to cover all such cases. In some places, a
> comment refers collectively to all the xid-related fields, which span both
> structures. I variously changed those to refer to either or both structures
> depending on how I judged the emphasis.
>
> The PGXACT patch extracted the PGPROC struct formerly embedded in each
> GlobalTransaction. I updated a few comments accordingly.
>
> The procarray.c leading comment described the procarray as "unsorted", but it
> is sorted by memory address; I removed that word.
>
> I include two typo-only fixes on related but already-accurate lines.
Thanks, applied!
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com