Re: pgsql: In pg_upgrade, avoid dumping orphaned temporary tables. This ma

In pg_upgrade, avoid dumping orphaned temporary tables. This makes the
pg_upgrade schema matching pattern match pg_dump/pg_dumpall.

Fix for 9.0, 9.1, and 9.2.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2411fbdac448045a23eebf4f0dbfd5790ebad720

Modified Files
--------------
contrib/pg_upgrade/info.c | 4 +++-
contrib/pg_upgrade/version_old_8_3.c | 14 +++++++++-----
2 files changed, 12 insertions(+), 6 deletions(-)

Any way to put David Byrne's name in here? He reported the bug and
sent a proposed fix.

Cheers,
David.
On Tue, Aug 16, 2011 at 02:40:19AM +0000, Bruce Momjian wrote:
> In pg_upgrade, avoid dumping orphaned temporary tables. This makes the
> pg_upgrade schema matching pattern match pg_dump/pg_dumpall.
>
> Fix for 9.0, 9.1, and 9.2.
>
> Branch
> ------
> master
>
> Details
> -------
> http://git.postgresql.org/pg/commitdiff/2411fbdac448045a23eebf4f0dbfd5790ebad720
>
> Modified Files
> --------------
> contrib/pg_upgrade/info.c | 4 +++-
> contrib/pg_upgrade/version_old_8_3.c | 14 +++++++++-----
> 2 files changed, 12 insertions(+), 6 deletions(-)
>
>
> --
> Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-committers

--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

David Fetter wrote:
> Any way to put David Byrne's name in here? He reported the bug and
> sent a proposed fix.

Do we report the reporter's name in commit messages? I can do that if
others are doing it. I don't think I can put it in now.

---------------------------------------------------------------------------

>
> Cheers,
> David.
> On Tue, Aug 16, 2011 at 02:40:19AM +0000, Bruce Momjian wrote:
> > In pg_upgrade, avoid dumping orphaned temporary tables. This makes the
> > pg_upgrade schema matching pattern match pg_dump/pg_dumpall.
> >
> > Fix for 9.0, 9.1, and 9.2.
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > http://git.postgresql.org/pg/commitdiff/2411fbdac448045a23eebf4f0dbfd5790ebad720
> >
> > Modified Files
> > --------------
> > contrib/pg_upgrade/info.c | 4 +++-
> > contrib/pg_upgrade/version_old_8_3.c | 14 +++++++++-----
> > 2 files changed, 12 insertions(+), 6 deletions(-)
> >
> >
> > --
> > Sent via pgsql-committers mailing list (pgsql-committers(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgsql-committers
>
> --
> David Fetter <david(at)fetter(dot)org> http://fetter.org/
> Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
> Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
> iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics
>
> Remember to vote!
> Consider donating to Postgres: http://www.postgresql.org/about/donate

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

On Tue, Aug 16, 2011 at 10:17 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> David Fetter wrote:
>> Any way to put David Byrne's name in here?  He reported the bug and
>> sent a proposed fix.
>
> Do we report the reporter's name in commit messages?

I usually do; Tom, too, I think.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Robert Haas wrote:
> On Tue, Aug 16, 2011 at 10:17 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > David Fetter wrote:
> >> Any way to put David Byrne's name in here? ?He reported the bug and
> >> sent a proposed fix.
> >
> > Do we report the reporter's name in commit messages?
>
> I usually do; Tom, too, I think.

OK.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote:
> David Fetter wrote:
> > Any way to put David Byrne's name in here? He reported the bug and
> > sent a proposed fix.
>
> Do we report the reporter's name in commit messages? I can do that if
> others are doing it. I don't think I can put it in now.

He didn't just report the bug. He sent patches to fix it, even if you
didn't base yours off his, so here's yours truly agitating to get him
credit :)

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

On 17 August 2011 06:13, David Fetter <david(at)fetter(dot)org> wrote:

> On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote:
> > David Fetter wrote:
> > > Any way to put David Byrne's name in here? He reported the bug and
> > > sent a proposed fix.
> >
> > Do we report the reporter's name in commit messages? I can do that if
> > others are doing it. I don't think I can put it in now.
>
> He didn't just report the bug. He sent patches to fix it, even if you
> didn't base yours off his, so here's yours truly agitating to get him
> credit :)
>

Can this now be removed as a beta-blocker?

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Aug 17, 2011 at 04:40:26PM +0100, Thom Brown wrote:
> On 17 August 2011 06:13, David Fetter <david(at)fetter(dot)org> wrote:
>
> > On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote:
> > > David Fetter wrote:
> > > > Any way to put David Byrne's name in here? He reported the bug and
> > > > sent a proposed fix.
> > >
> > > Do we report the reporter's name in commit messages? I can do that if
> > > others are doing it. I don't think I can put it in now.
> >
> > He didn't just report the bug. He sent patches to fix it, even if you
> > didn't base yours off his, so here's yours truly agitating to get him
> > credit :)
>
> Can this now be removed as a beta-blocker?

I'm missing some context. Is there a URL associated with this
blockage?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

On 17 August 2011 17:02, David Fetter <david(at)fetter(dot)org> wrote:

> On Wed, Aug 17, 2011 at 04:40:26PM +0100, Thom Brown wrote:
> > On 17 August 2011 06:13, David Fetter <david(at)fetter(dot)org> wrote:
> >
> > > On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote:
> > > > David Fetter wrote:
> > > > > Any way to put David Byrne's name in here? He reported the bug and
> > > > > sent a proposed fix.
> > > >
> > > > Do we report the reporter's name in commit messages? I can do that
> if
> > > > others are doing it. I don't think I can put it in now.
> > >
> > > He didn't just report the bug. He sent patches to fix it, even if you
> > > didn't base yours off his, so here's yours truly agitating to get him
> > > credit :)
> >
> > Can this now be removed as a beta-blocker?
>
> I'm missing some context. Is there a URL associated with this
> blockage?

Sure, it's generally tracked on the wiki:
http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items

--
Thom Brown
Twitter: @darkixion
IRC (freenode): dark_ixion
Registered Linux user: #516935

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Wed, Aug 17, 2011 at 05:12:49PM +0100, Thom Brown wrote:
> On 17 August 2011 17:02, David Fetter <david(at)fetter(dot)org> wrote:
>
> > On Wed, Aug 17, 2011 at 04:40:26PM +0100, Thom Brown wrote:
> > > On 17 August 2011 06:13, David Fetter <david(at)fetter(dot)org> wrote:
> > >
> > > > On Tue, Aug 16, 2011 at 10:17:21PM -0400, Bruce Momjian wrote:
> > > > > David Fetter wrote:
> > > > > > Any way to put David Byrne's name in here? He reported the bug and
> > > > > > sent a proposed fix.
> > > > >
> > > > > Do we report the reporter's name in commit messages? I can do that
> > if
> > > > > others are doing it. I don't think I can put it in now.
> > > >
> > > > He didn't just report the bug. He sent patches to fix it, even if you
> > > > didn't base yours off his, so here's yours truly agitating to get him
> > > > credit :)
> > >
> > > Can this now be removed as a beta-blocker?
> >
> > I'm missing some context. Is there a URL associated with this
> > blockage?
>
>
> Sure, it's generally tracked on the wiki:
> http://wiki.postgresql.org/wiki/PostgreSQL_9.1_Open_Items

OK, that's probably moving to "resolved issues."

By the way, the wiki is now tracking bugs. We have a bug tracker, and
it's that. At some point in the very, very near future, we will have
to make some painful decisions about whether we continue with /ad hoc/
bug tracking such as, "It's on the wiki, somewhere, if everybody
remembers to put it there" vs. more formal systems, the details of
which are TBB*.

Cheers,
David.

* To Be Bikeshedded
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Excerpts from David Fetter's message of mié ago 17 12:31:14 -0400 2011:

> By the way, the wiki is now tracking bugs. We have a bug tracker, and
> it's that.

Yeah, but only during each release's last mile. Also consider that
any bug found to exist on older releases is not normally added to the
list of blockers.

--
Álvaro Herrera <alvherre(at)commandprompt(dot)com>
The PostgreSQL Company - Command Prompt, Inc.
PostgreSQL Replication, Consulting, Custom Development, 24x7 support