BUG #5617: pg_restore behaves unexpectedly on 'invalid' command line

Lists: pgsql-bugs
From: "Leo Shklovskii" <leo(at)thermopylae(dot)net>
To: pgsql-bugs(at)postgresql(dot)org
Subject: BUG #5617: pg_restore behaves unexpectedly on 'invalid' command line
Date: 2010-08-13 00:01:17
Message-ID: 201008130001.o7D01H44012475@wwwmaster.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs


The following bug has been logged online:

Bug reference: 5617
Logged by: Leo Shklovskii
Email address: leo(at)thermopylae(dot)net
PostgreSQL version: 8.4.4
Operating system: Windows 7 (x86)
Description: pg_restore behaves unexpectedly on 'invalid' command
line
Details:

If I put options after the filename to use for pg_restore.exe then it
behaves in a very unintuitive way. So, for example:

pg_restore.exe -U postgres d8.dump -d d8a

This should either result in the command working as expected, or an error
that the args weren't correct. I understand that arg parsing can be hard in
situations so the latter would be perfectly fine.

Instead, I get a dump of the SQL generated to the screen which is a mess and
its hard to figure out that you did something wrong.


From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Leo Shklovskii" <leo(at)thermopylae(dot)net>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #5617: pg_restore behaves unexpectedly on 'invalid' command line
Date: 2010-08-13 13:59:17
Message-ID: 22667.1281707957@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

"Leo Shklovskii" <leo(at)thermopylae(dot)net> writes:
> If I put options after the filename to use for pg_restore.exe then it
> behaves in a very unintuitive way.

Hmm ... pg_dump is coded to complain about that, but pg_restore just
ignores any "extra" arguments after the filename. I agree that's not
too good, will fix.

regards, tom lane