pgsql: Add restart_after_crash GUC.

Lists: pgsql-committerspgsql-hackers
From: rhaas(at)postgresql(dot)org (Robert Haas)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Add restart_after_crash GUC.
Date: 2010-07-20 00:47:53
Message-ID: 20100720004753.3BE677541D5@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Add restart_after_crash GUC.

Normally, we automatically restart after a backend crash, but in some
cases when PostgreSQL is invoked by clusterware it may be desirable to
suppress this behavior, so we provide an option which does this.
Since no existing GUC group quite fits, create a new group called
"error handling options" for this and the previously undocumented GUC
exit_on_error, which is now documented.

Review by Fujii Masao.

Modified Files:
--------------
pgsql/doc/src/sgml:
config.sgml (r1.297 -> r1.298)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=1.297&r2=1.298)
pgsql/src/backend/postmaster:
postmaster.c (r1.614 -> r1.615)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c?r1=1.614&r2=1.615)
pgsql/src/backend/utils/misc:
check_guc (r1.10 -> r1.11)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/check_guc?r1=1.10&r2=1.11)
guc.c (r1.563 -> r1.564)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.563&r2=1.564)
postgresql.conf.sample (r1.292 -> r1.293)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/postgresql.conf.sample?r1=1.292&r2=1.293)
pgsql/src/include/postmaster:
postmaster.h (r1.22 -> r1.23)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/postmaster/postmaster.h?r1=1.22&r2=1.23)
pgsql/src/include/utils:
guc_tables.h (r1.49 -> r1.50)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/guc_tables.h?r1=1.49&r2=1.50)

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add restart_after_crash GUC.
Date: 2010-07-27 06:33:46
Message-ID: AANLkTimms2Cyu1XCfUYh=ZwgY5-+nAAD44b-CVOUYxPM@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 20, 2010 at 9:47 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
> Log Message:
> -----------
> Add restart_after_crash GUC.

In postgresql.conf.sample, on/off is used as a boolean value.
But true/false is used for exit_on_error and restart_after_crash.
Sorry, I had overlooked that inconsistency when reviewing the
original patch. I attached the bug-fix patch.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
true_false_to_on_off_0727.patch application/octet-stream 793 bytes
From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add restart_after_crash GUC.
Date: 2010-07-27 16:07:00
Message-ID: AANLkTi=xEn_UYJCMf==ZXn-Ri_9MKQKa=L4NXCc24n7y@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Tue, Jul 27, 2010 at 2:33 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Jul 20, 2010 at 9:47 AM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> Log Message:
>> -----------
>> Add restart_after_crash GUC.
>
> In postgresql.conf.sample, on/off is used as a boolean value.
> But true/false is used for exit_on_error and restart_after_crash.
> Sorry, I had overlooked that inconsistency when reviewing the
> original patch. I attached the bug-fix patch.

Good catch, thanks. Committed.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company