pgsql: Mark PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 with PGDLLEXPORT

Lists: pgsql-committerspgsql-hackers
From: itagaki(at)postgresql(dot)org (Takahiro Itagaki)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Mark PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 with PGDLLEXPORT
Date: 2010-05-27 07:59:49
Message-ID: 20100527075949.339A17541D2@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Log Message:
-----------
Mark PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 with PGDLLEXPORT
independently from BUILDING_DLL. It is always __declspec(dllexport).

Modified Files:
--------------
pgsql/src/include:
c.h (r1.240 -> r1.241)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/c.h?r1=1.240&r2=1.241)
fmgr.h (r1.65 -> r1.66)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/fmgr.h?r1=1.65&r2=1.66)
pgsql/src/include/port:
cygwin.h (r1.7 -> r1.8)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/port/cygwin.h?r1=1.7&r2=1.8)
win32.h (r1.93 -> r1.94)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/port/win32.h?r1=1.93&r2=1.94)


From: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
To: Takahiro Itagaki <itagaki(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Mark PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 with PGDLLEXPORT
Date: 2010-05-28 11:57:57
Message-ID: 4BFFAFC5.9030807@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On 27/05/10 10:59, Takahiro Itagaki wrote:
> Log Message:
> -----------
> Mark PG_MODULE_MAGIC and PG_FUNCTION_INFO_V1 with PGDLLEXPORT
> independently from BUILDING_DLL. It is always __declspec(dllexport).

It looks like the Windows buildfarm members are not happy about this
change...

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com