| Lists: | pgsql-hackers |
|---|
| From: | Matthew Altus <maltus(at)internode(dot)com(dot)au> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Alias to rollback keyword |
| Date: | 2010-04-01 00:42:14 |
| Message-ID: | 201004011112.14979.maltus@internode.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Hey,
After dealing with a production fault and having to rollback all the time, I
kept typing a different word instead of rollback. So I created a patch to
accept this word as an alias for rollback. Obviously it's not part of the sql
standard, but could be a nice extension for postgresql. See the patch for
more details.
Cheers
Matt
| Attachment | Content-Type | Size |
|---|---|---|
| pgsql_rollback.patch | text/x-patch | 842 bytes |
| From: | "David E(dot) Wheeler" <david(at)kineticode(dot)com> |
|---|---|
| To: | Matthew Altus <maltus(at)internode(dot)com(dot)au> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Alias to rollback keyword |
| Date: | 2010-04-01 02:33:49 |
| Message-ID: | 48BED3E5-D7B5-479A-A260-F8D15FB73F5F@kineticode.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Mar 31, 2010, at 5:42 PM, Matthew Altus wrote:
> After dealing with a production fault and having to rollback all the time, I
> kept typing a different word instead of rollback. So I created a patch to
> accept this word as an alias for rollback. Obviously it's not part of the sql
> standard, but could be a nice extension for postgresql. See the patch for
> more details.
+100
Best,
David
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Matthew Altus <maltus(at)internode(dot)com(dot)au> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Alias to rollback keyword |
| Date: | 2010-04-01 02:34:41 |
| Message-ID: | 201004010234.o312YfI04684@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Matthew Altus wrote:
> Hey,
>
> After dealing with a production fault and having to rollback all the time, I
> kept typing a different word instead of rollback. So I created a patch to
> accept this word as an alias for rollback. Obviously it's not part of the sql
> standard, but could be a nice extension for postgresql. See the patch for
> more details.
Applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Matthew Altus <maltus(at)internode(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Alias to rollback keyword |
| Date: | 2010-04-01 02:38:42 |
| Message-ID: | z2k603c8f071003311938k1a6718dfsd0e8c756dbcc713@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> Matthew Altus wrote:
>> Hey,
>>
>> After dealing with a production fault and having to rollback all the time, I
>> kept typing a different word instead of rollback. So I created a patch to
>> accept this word as an alias for rollback. Obviously it's not part of the sql
>> standard, but could be a nice extension for postgresql. See the patch for
>> more details.
>
> Applied.
You know, I was about to write a rant about this, until I realized
what day it will be soon (or already is, UTC).
...Robert
| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Matthew Altus <maltus(at)internode(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Alias to rollback keyword |
| Date: | 2010-04-01 02:39:36 |
| Message-ID: | 201004010239.o312dau05575@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
Robert Haas wrote:
> On Wed, Mar 31, 2010 at 10:34 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > Matthew Altus wrote:
> >> Hey,
> >>
> >> After dealing with a production fault and having to rollback all the time, I
> >> kept typing a different word instead of rollback. ?So I created a patch to
> >> accept this word as an alias for rollback. ?Obviously it's not part of the sql
> >> standard, but could be a nice extension for postgresql. ?See the patch for
> >> more details.
> >
> > Applied.
>
> You know, I was about to write a rant about this, until I realized
> what day it will be soon (or already is, UTC).
CVS is GMT-based.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
| From: | "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Alias to rollback keyword |
| Date: | 2010-04-01 14:39:04 |
| Message-ID: | 20100401143904.GA31194@rice.edu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2010 at 10:34:41PM -0400, Bruce Momjian wrote:
> Matthew Altus wrote:
> > Hey,
> >
> > After dealing with a production fault and having to rollback all the time, I
> > kept typing a different word instead of rollback. So I created a patch to
> > accept this word as an alias for rollback. Obviously it's not part of the sql
> > standard, but could be a nice extension for postgresql. See the patch for
> > more details.
>
> Applied.
Hmm, a careful review of the patch leads me to believe that this is one
of the few times that a keyword might benefit from localization. Seems
l10n efforts in this area have mostly focused on the filtering case, but
I'm sure we can repurose such lists. Licensing might be an issue.
Clearly this needs to be controlled by the client locale, not the
server. Any need for a guc?
Ross
--
Ross Reedstrom, Ph.D. reedstrm(at)rice(dot)edu
Systems Engineer & Admin, Research Scientist phone: 713-348-6166
The Connexions Project http://cnx.org fax: 713-348-3665
Rice University MS-375, Houston, TX 77005
GPG Key fingerprint = F023 82C8 9B0E 2CC6 0D8E F888 D3AE 810E 88F0 BEDE